Skip to content

Refuse an unknown awesIO minor version while the schema is below 1.0 #11

Open

Description

@1-Bort-1

The viewer refuses a structure document whose awesIO major version it does not know, and only warns on a newer minor. That fit awesIO 1.x. The vendored schema is now awesIO 0.1.0, and below 1.0 semver lets a minor release break readers, so a 0.2.0 document that renamed or dropped a column would be read with a warning and then fail or draw wrongly further in.

The awesIO schema itself states no compatibility rule: awesIO_version is described only as the version the file was written against. So which bump a reader may cross is not written down anywhere a second reader (KiteGeometry) shares.

What I would do: have awesIO state the rule once beside awesIO_version (below 1.0, the minor is the breaking part), and have the viewer refuse an unknown minor while the major is 0, with the same message naming both versions. That is a decision for the owner, so it is not in #10.

Found in the review of #10.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions