[1-Bort-1]

Drop load_authoring's place keyword; it always places the definition

Loading an authoring file could leave the definition unplaced, in its design pose, so that SymbolicAWEModels could place it itself. SymbolicAWEModels now takes the placed definition directly (OpenSourceAWE/SymbolicAWEModels.jl#424), so no caller uses that option. SymbolicAWEModels' main never passes it (it requires the registered KiteGeometry 0.2, which lacks it), so this can merge before or after OpenSourceAWE/SymbolicAWEModels.jl#424. This removes it, with its test and its changelog line, so a placed definition is the only thing loading returns.

The option was added in #68 and is in no release, so nobody is broken and the changelog gets no Removed entry.

load_authoring(path; set, place=false)   # before: design pose
load_authoring(path; set)                # after: always placed

Verification

• Reproduced first: n/a — an API removal
• No other use of the keyword in src/, test/ or docs/ (searched for place=)
• test/test-authoring.jl: 649/649 pass · test/test-transforms.jl: 25/25 pass
• Docs build clean
• REUSE lint: green in GitHub CI (reuse-lint); not run locally, reuse is not installed on this box
• SymbolicAWEModels main: no place= in any call to load_authoring (grepped a fresh clone)
• GitHub CI tests and docs: still running when this was written
• Risk: a caller outside the OpenSourceAWE repos passing place=false from an unreleased checkout now gets a keyword error.

[1-Bort-1]

Independent review (advisory)

Verdict: APPROVE · 0 inline, 0 off the diff

Good

• The diff does what the card says and nothing else: the keyword is gone from both methods, the forwarding call, both docstring signatures and the prose, and its CHANGELOG line and test are deleted; checked against the card's before/after snippet.
• The place && guard is gone, so place_authored! always runs, and design = copy(Pose(placement)) is still used by placed_definition, so no dead local is left; checked src/authoring.jl:919-923.
• No leftover place= or place_authored in src, docs (outside docs/build) or test; the only remaining 'design pose' text describes design_pose itself, which still exists; checked with grep.
• The deleted test's elevation ≈ 50 check still runs in the placed-definition test at test/test-authoring.jl:227, and placement is still covered there and by the tether test, so no coverage is lost.
• The docstring signature now fits on one line within 92 columns, and its prose ends with what is true ('The definition is placed') with no countermand.
• Dropping the changelog line instead of adding a Removed entry is right because the option is in no release, as the card says.

Not good

• The card says SymbolicAWEModels takes the placed definition via #424, but it does not say whether #424 has merged. If it has not, SAM's main still passing place=false would break with a keyword error when this lands, so the merge order should be stated.
• Verification lists REUSE lint as not run and CI as pending. That is low risk for a deletion-only diff, but it is still unverified.

_{claude, rubric CLEAN_CODE.md. A different lab from the implementer
on purpose: a reviewer sharing its blind spots would not flag its mistakes.}

[1-Bort-1]

The description was rewritten here since the box last wrote it, so it stays as it is. This is what the box would have put there:

Loading an authoring file could leave the definition unplaced, in its design pose, so that SymbolicAWEModels could place it itself. SymbolicAWEModels now takes the placed definition directly (OpenSourceAWE/SymbolicAWEModels.jl#424), so no caller uses that option. SymbolicAWEModels' main never passes it (it requires the registered KiteGeometry 0.2, which lacks it), so this can merge before or after OpenSourceAWE/SymbolicAWEModels.jl#424. This removes it, with its test and its changelog line, so a placed definition is the only thing loading returns.

The option was added in #68 and is in no release, so nobody is broken and the changelog gets no Removed entry.

load_authoring(path; set, place=false)   # before: design pose
load_authoring(path; set)                # after: always placed

Verification

• Reproduced first: n/a — an API removal
• No other use of the keyword in src/, test/ or docs/ (searched for place=)
• test/test-authoring.jl: 649/649 pass · test/test-transforms.jl: 25/25 pass
• Docs build clean
• REUSE lint: green in GitHub CI (reuse-lint); not run locally, reuse is not installed on this box
• SymbolicAWEModels main: no place= in any call to load_authoring (grepped a fresh clone)
• GitHub CI tests and docs: still running when this was written
• Risk: a caller outside the OpenSourceAWE repos passing place=false from an unreleased checkout now gets a keyword error.

Opened by 1-Bort-1, an AI agent working for @1-Bart-1.
Closes #72 · task KiteGeometry.jl-72
Refs OpenSourceAWE/SymbolicAWEModels.jl#421

[1-Bort-1]

REUSE lint is green in GitHub CI (reuse-lint check); the card now says so. The tests and docs jobs were still running when I updated the card, and it marks them unchecked.

[1-Bort-1]

Local full suite: PASS (1 min, Julia 1.13.0, one cell of the matrix)

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!