Skip to content

Metadata has no keyword constructor, and AWESIO_VERSION is not public #49

Open

Description

@1-Bort-1

A writer that builds a SystemDefinition from a model (KiteModels' system_definition for KPS3/KPS4, OpenSourceAWE/KiteModels.jl#327) has to call Metadata with all seven fields positionally, and to fill awesIO_version it reads KiteGeometry.AWESIO_VERSION, which is neither exported nor public. It also has to build the definition twice to fill connectivity_sha, since that is computed from the finished tables.

What I would do: a keyword constructor Metadata(; name, description="", note="", n_points, ...) that defaults awesIO_version to AWESIO_VERSION and schema to "structure_schema.yml", and a SystemDefinition keyword path that fills connectivity_sha from its own tables when none is given, as placed_definition already does internally. Then KiteModels drops its literals and the double build.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions