Conversation
pmai
force-pushed
the
feature/osi-python-mcap
branch
from
a0de251 to
5fe03e2
Compare
asadekasam
added
ReadyForCCBReview
Signed-off-by: Pierre R. Mai <pmai@pmsf.de>
TimmRuppert
reviewed
Nov 6, 2025
pmai
force-pushed
the
feature/osi-python-mcap
branch
from
5fe03e2 to
5fe9385
Compare
Signed-off-by: Pierre R. Mai <pmai@pmsf.de>
pmai
force-pushed
the
feature/osi-python-mcap
branch
from
5fe9385 to
7af3060
Compare
TimmRuppert
approved these changes
Nov 6, 2025
Contributor
TimmRuppert
left a comment
TimmRuppert
left a comment
There was a problem hiding this comment.
Except the two code suggestions looks good and works fine: I created some test files using the asam-osi-utilities/tree/main/examples and issues were found/not found as expected.
Thanks for all the contributions!
Comment on lines
71
to
74
| config.get_config_param("InputFile"), | ||
| config.get_config_param("osiType"), | ||
| False, | ||
| config.get_config_param("osiTopic"), |
Contributor
There was a problem hiding this comment.
Suggested change
| config.get_config_param("InputFile"), | |
| config.get_config_param("osiType"), | |
| False, | |
| config.get_config_param("osiTopic"), | |
| path= config.get_config_param("InputFile"), | |
| type_name = config.get_config_param("osiType"), | |
| cache_messages = False, | |
| topic = config.get_config_param("osiTopic"), |
I know you wanted a review that it works but I could not resist to also look at the code ;)
As we just changed the interface and this priject also follows the latest osi python main I would recommend to change to keywords (to even fail a little bit earlier and more clear).
Comment on lines
473
to
476
| config.get_config_param("InputFile"), | ||
| expected_type_name, | ||
| False, | ||
| config.get_config_param("osiTopic"), |
Contributor
There was a problem hiding this comment.
Same as above
Suggested change
| config.get_config_param("InputFile"), | |
| expected_type_name, | |
| False, | |
| config.get_config_param("osiTopic"), | |
| path= config.get_config_param("InputFile"), | |
| type_name = expected_type_name, | |
| cache_messages = False, | |
| topic = config.get_config_param("osiTopic"), |
Add tests to ensure topic is correctly ignored for single trace files, also fix formatting error in related_to code. Signed-off-by: Pierre R. Mai <pmai@pmsf.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switches to osi-python bindings for transparent MCAP support