Skip to content

Enhancement of documentation for better explaining static/dynamic lin… #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 27, 2023

Conversation

PhRosenberger
Copy link
Contributor

Reference to a related issue in the repository

Relates to

Add a description

We need better install instructions for static / dynamic linking, so this PR should enhance the README for this.
More explanation should then follow in the OSI documentation, I guess?

Take this checklist as orientation for yourself, if this PR is ready for the Change Control Board:

  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation for osi-sensor-model-packaging.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests / Github Actions pass locally with my changes.

…king

Signed-off-by: Philipp Rosenberger <philipp.rosenberger@persival.de>
@jdsika
Copy link
Contributor

jdsika commented Feb 22, 2023

consider placeholder for version

Signed-off-by: Philipp Rosenberger <philipp.rosenberger@partner.bmw.de>
@PhRosenberger PhRosenberger force-pushed the 87-file-already-exists-in-database-windows branch from 4c1fa0e to 6df9126 Compare March 13, 2023 09:55
@PhRosenberger
Copy link
Contributor Author

Install instructions are located only at one place in the documentation now. OSMP docu (part) just has to link to it then.

(empty line before title can have technical implications)

Signed-off-by: Philip Windecker <philip.windecker@avenyr.de>
@PhRosenberger PhRosenberger requested a review from pmai March 14, 2023 10:16
@PhRosenberger PhRosenberger added the ReadyForCCBReview Indicates that this MR is ready for a final review and merge by the CCB. label Mar 14, 2023
Signed-off-by: Pierre R. Mai <pmai@pmsf.de>

Co-authored-by: Philip Windecker <95633467+philipwindecker@users.noreply.github.com>
@pmai
Copy link
Contributor

pmai commented Mar 27, 2023

CCB on 2023-03-27: Merge as-is.

@pmai pmai added ReadyToMerge and removed ReadyForCCBReview Indicates that this MR is ready for a final review and merge by the CCB. labels Mar 27, 2023
@pmai pmai merged commit 133e79b into master Mar 27, 2023
@PhRosenberger PhRosenberger mentioned this pull request Mar 27, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Everything which impacts the quality of the documentation and guidelines. ReadyToMerge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

File already exists in database (Windows)
4 participants