Skip to content

Build: Create features for a combined release pipeline #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 30 commits into from
Mar 31, 2023

Conversation

philipwindecker
Copy link
Contributor

@philipwindecker philipwindecker commented Jan 30, 2023

IMPORTANT: Remove local workarounds before merging!

Add a description

This PR adds features used in creating new OSI releases.
Particularly, this adds a new pipeline to react to external triggers in order to create new tags.
These tags are used by the Antora generator to build a cohesive version of OSI over all involved repositories.
Additionally, a second, OSMP-specific tag is created and the Examples build pipeline is triggered.
Lastly, the generated Examples are then uploaded as a new attachment to the OSI release.

Mention a member

@pmai

Check the checklist

  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation for osi-sensor-model-packaging.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests / Github Actions pass locally with my changes.

Related PRs

philipwindecker and others added 27 commits January 9, 2023 13:36
Excempt changes in .github/ and .gitmodules from triggering this workflow
Excempt changes in .github/ and .gitmodules from triggering this workflow
Added suffix to full release
Added repo dispatch for creating examples
Added conditional step for uploading built artifacts to a release in interface repo (triggered)
Added missing dependency for artifacts
changed directory to path for artifacts
Switch to VERSION file for OSMP
Added relative path
Moved condition into brackets
Changed to 'x-antora'-tag
@philipwindecker philipwindecker changed the title Draft: Create features for a combined release pipeline Build: Create features for a combined release pipeline Jan 30, 2023
@philipwindecker
Copy link
Contributor Author

IMPORTANT: Remove local workarounds before merging!

@philipwindecker philipwindecker requested a review from pmai January 30, 2023 10:01
Signed-off-by: Philip Windecker <philip.windecker@avenyr.de>
@philipwindecker philipwindecker marked this pull request as ready for review March 27, 2023 10:26
@philipwindecker
Copy link
Contributor Author

As dicussed in today's CCB meeting, I removed the workarounds pointing to forked repositories.
Changes can now be merged. Please add review so I can proceed, @pmai .

Note that I will need to confirm operation after merge to make sure all changes work as intended here as well.

Signed-off-by: Philip Windecker <philip.windecker@avenyr.de>
Copy link
Contributor

@pmai pmai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved as per CCB 2023-03-27.

@philipwindecker philipwindecker merged commit 854927a into OpenSimulationInterface:master Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quality Quality improvements.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants