Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

webview: Check id before showing track menu #4758

Merged
merged 1 commit into from
Apr 3, 2022
Merged

webview: Check id before showing track menu #4758

merged 1 commit into from
Apr 3, 2022

Conversation

ferdnyc
Copy link
Contributor

@ferdnyc ferdnyc commented Apr 2, 2022

Just hit a traceback with this; we already have these same protections on the Clip and Effect references, but it seems invalid (just-deleted) Tracks can also be the target of new menu requests.

@ferdnyc ferdnyc added 🐞 bug A bug, error, or breakage of any kind interface GUI / user interface issues (i.e. windows, buttons, scrolling, pop-ups, etc...) timeline An issue or PR involving the HTML/JS/CSS timeline implementation labels Apr 2, 2022
@ferdnyc
Copy link
Contributor Author

ferdnyc commented Apr 3, 2022

Merging as painfully uncontroversial.

@ferdnyc ferdnyc merged commit 2ee9307 into develop Apr 3, 2022
@ferdnyc ferdnyc deleted the track-menu-check branch April 3, 2022 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
interface GUI / user interface issues (i.e. windows, buttons, scrolling, pop-ups, etc...) 🐞 bug A bug, error, or breakage of any kind timeline An issue or PR involving the HTML/JS/CSS timeline implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ferdnyc