-
Notifications
You must be signed in to change notification settings - Fork 551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Freeze and unfreeze toolbar along with other windows. #4656
Conversation
@JacksonRG Makes sense to me! The only concern I have is that freezing the view while the toolbar is floating makes it non-movable. (Which isn't the case with a floated dock, because it's still a window that can be dragged by its titlebar.) So I wonder if maybe there should be a check of And then we'd want to link the movability to the floating status, so that it freezes once it gets docked (if the interface is frozen)... actually, I came up with some things, I'll open a PR against this branch for you to look at. |
@ferdnyc |
@JacksonRG Heh. Yeah, GNOME Shell can drag any window (or other onscreen element) using Super+LMB, but that's cheating! |
c161a61
to
f22fea3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once the CI build finishes, I'll go ahead and merge this.
|
@JacksonRG Yeah, I had to do a little history rewriting to get the post-my-PR-merge branch properly rebased on top of current |
Closes #4255
Issue:
When freezing the view, toolbar could still be dragged around.
Fix:
Toggle
toolBar.movable
along with the other dock widgets.