Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Freeze and unfreeze toolbar along with other windows. #4656

Merged
merged 2 commits into from
Feb 7, 2022

Conversation

JacksonRG
Copy link
Collaborator

Closes #4255

Issue:
When freezing the view, toolbar could still be dragged around.

Fix:
Toggle toolBar.movable along with the other dock widgets.

@ferdnyc
Copy link
Contributor

ferdnyc commented Feb 3, 2022

@JacksonRG Makes sense to me! The only concern I have is that freezing the view while the toolbar is floating makes it non-movable. (Which isn't the case with a floated dock, because it's still a window that can be dragged by its titlebar.)

So I wonder if maybe there should be a check of toolBar.floating, first, before it's potentially frozen? Just so we don't stick people with any non-draggable screen elements.

And then we'd want to link the movability to the floating status, so that it freezes once it gets docked (if the interface is frozen)... actually, I came up with some things, I'll open a PR against this branch for you to look at.

@JacksonRG
Copy link
Collaborator Author

@ferdnyc
Good thinking! I have window dragging bound to a key, so I hadn't noticed. That's a reminder for me to get out of my window manager occasionally.

@ferdnyc
Copy link
Contributor

ferdnyc commented Feb 5, 2022

@JacksonRG Heh. Yeah, GNOME Shell can drag any window (or other onscreen element) using Super+LMB, but that's cheating!

@ferdnyc ferdnyc force-pushed the include-toolbar-in-freeze branch from c161a61 to f22fea3 Compare February 7, 2022 17:05
Copy link
Contributor

@ferdnyc ferdnyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the CI build finishes, I'll go ahead and merge this.

@ferdnyc ferdnyc added the interface GUI / user interface issues (i.e. windows, buttons, scrolling, pop-ups, etc...) label Feb 7, 2022
@JacksonRG
Copy link
Collaborator Author

Once the CI build finishes, I'll go ahead and merge this.
Ty, I was about to merge on Friday, but had merge conflicts for some reason.

@ferdnyc ferdnyc merged commit 502a7d4 into develop Feb 7, 2022
@ferdnyc ferdnyc deleted the include-toolbar-in-freeze branch February 7, 2022 19:12
@ferdnyc
Copy link
Contributor

ferdnyc commented Feb 7, 2022

@JacksonRG Yeah, I had to do a little history rewriting to get the post-my-PR-merge branch properly rebased on top of current develop and mergeable, but I eventually sorted it out. (Hopefully, we'll see what develop's history looks like now that it's merged.)

@ferdnyc
Copy link
Contributor

ferdnyc commented Feb 7, 2022

Huh. Looks fine, actually.

image

Well, cool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
interface GUI / user interface issues (i.e. windows, buttons, scrolling, pop-ups, etc...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Freeze View does not lock toolbar
2 participants