Presets: Add MKV (h.264) sw/hw presets #4637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Clone every `format_mp4_x64*.xml` preset into an equivalent `format_mkv_x264*.xml` preset, with only the title and container format changed.
ferdnyc
added
the
media-handling
ferdnyc
added a commit
that referenced
this pull request
Feb 7, 2022
- Clone every `format_mp4_x64*.xml` preset into an equivalent `format_mkv_x264*.xml` preset, with only the title and container format changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have no idea why I never opened this PR, I did the initial commit nearly a year ago and then just forgot about it apparently. But, that's OK, as it gave me a chance to go back and add the hardware presets as well, just now.
This PR creates greater parity between our MKV (Matroska) preset offerings — of which there were previously, like, two — and our MP4 preset offerings, which are extensive.
Every
format_mp4_x64*.xmlpreset is cloned into an equivalentformat_mkv_x264*.xmlpreset, with only the title and container format changed.(TBH we should probably do something like what Handbrake does, and just let the user select between MP4 container and MKV container for every MP4 preset, since the containers are virtually interchangeable. Then we'd have a lot less preset clutter, instead of a bit more like this will introduce. But, it's worth giving people options IMHO.)
I feel like this was in response to a request someone made in an Issue, or something, but I'm not going to try and find it because Stale would've closed it long ago anyway.