Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webkit feature parity #4321

Merged
merged 4 commits into from
Nov 9, 2021
Merged

Webkit feature parity #4321

merged 4 commits into from
Nov 9, 2021

Conversation

JacksonRG
Copy link
Collaborator

  1. When the window is resized, parts of the ruler that weren't visible had no ruler marks. Now, changes in width attribute the ruler's parent container should trigger redrawing. (Thought that was fixed in my last PR)
  2. Horizontal scrolling hasn't worked for me when running with the webkit backend. Now both web backends should respond to shift+mousewheel as horizontal scrolling

Copy link
Contributor

@ferdnyc ferdnyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The shifted horizontal scrolling does work for me now, but it's very jerky on Linux and keeps trying to scroll vertically at times, especially when I reverse direction while holding down Shift. I suspect a .preventDefault() is needed.

src/timeline/js/directives/ruler.js Outdated Show resolved Hide resolved
@ferdnyc
Copy link
Contributor

ferdnyc commented Oct 17, 2021

Oh, nice, and tilt-wheel horizontal scrolling still works as well.

@ferdnyc ferdnyc merged commit ab9e763 into develop Nov 9, 2021
@ferdnyc ferdnyc deleted the webkit-feature-parity branch November 9, 2021 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants