Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update windows-installer.iss #3732

Closed
wants to merge 1 commit into from
Closed

Conversation

dscotese
Copy link
Contributor

The description of the firewall exception now explains itself. This is a proposed fix for #2305 .

The description of the firewall exception now explains itself.
@ferdnyc
Copy link
Contributor

ferdnyc commented Sep 23, 2020

@dscotese Hmmm. The only thing I'm wondering is if we should explicitly say that the anonymous data submission is "optional".

I mean, no amount of... ... ... user-proofing will prevent the more determined types from finding a way to feel we've somehow violated them, no matter how much we bend over backwards to avoid sneezing without first submitting a written request for violent nasal expulsion. But that being said, we may want to avoid leaving room for the interpretation that simply installing that firewall exception enables reporting. They still also have to check the "Yes, I would like to improve OpenShot" box in the tutorial.

(TBH, if we were Windows-only we probably could use the firewall checkbox to opt them in to reporting, and not have to effectively ask a second time in the tutorial. But, that wouldn't work for Linux and Mac users, and it's really not worth the special-casing to do it that way only on Windows.)

@ferdnyc ferdnyc added OS:Windows Issues specific to the Windows operating system 📦 packaging An issue or PR related to the official package builds labels Sep 23, 2020
@dscotese dscotese closed this Sep 23, 2020
@dscotese dscotese deleted the patch-1 branch September 23, 2020 21:38
@ferdnyc
Copy link
Contributor

ferdnyc commented Sep 23, 2020

? @dscotese For the record, I was only suggesting that the word "optional" be added to your updated text. (That could've been done within this PR, it's possible to update a PR branch after submitting it. But if you just closed this to resubmit with different wording, that's great too.)

@ferdnyc
Copy link
Contributor

ferdnyc commented Sep 23, 2020

Oooh, hey, it seems Windows Firewall rules can have a description field:

image

We should figure out how to set that, too.

image

dscotese added a commit to dscotese/openshot-qt that referenced this pull request Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS:Windows Issues specific to the Windows operating system 📦 packaging An issue or PR related to the official package builds
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants