Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File Properties: Some tweaks to raise the profile of the JSON data dump #3441

Merged
merged 1 commit into from
May 5, 2020
Merged

File Properties: Some tweaks to raise the profile of the JSON data dump #3441

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
File Properties: Raise profile of JSON data dump 
- Move the JSON text from being buried in a too-small widget stuffed at
  the bottom of the QToolBox, to having its own tab next to 'Details'
- Retitle the tab/section from 'Output' to 'JSON'
- Allow text selection via mouse AND(/or) keyboard
- Disable hard-to-read line wrapping; the dialog can be widened
  • Loading branch information
@ferdnyc
ferdnyc committed May 3, 2020
commit 158d06a586e79969e58a2c22218228cbec0668c5
72 changes: 49 additions & 23 deletions src/windows/ui/file-properties.ui
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,8 +191,8 @@
<rect>
<x>0</x>
<y>0</y>
<width>354</width>
<height>222</height>
<width>367</width>
<height>245</height>
</rect>
</property>
<property name="sizePolicy">
Expand Down Expand Up @@ -502,9 +502,9 @@
<property name="geometry">
<rect>
<x>0</x>
<y>-28</y>
<width>354</width>
<height>117</height>
<y>0</y>
<width>367</width>
<height>127</height>
</rect>
</property>
<attribute name="label">
Expand Down Expand Up @@ -616,9 +616,9 @@
<property name="geometry">
<rect>
<x>0</x>
<y>-98</y>
<width>354</width>
<height>187</height>
<y>0</y>
<width>367</width>
<height>205</height>
</rect>
</property>
<attribute name="label">
Expand Down Expand Up @@ -816,7 +816,7 @@
<x>0</x>
<y>0</y>
<width>367</width>
<height>89</height>
<height>90</height>
</rect>
</property>
<attribute name="label">
Expand Down Expand Up @@ -897,20 +897,46 @@
</item>
</layout>
</widget>
<widget class="QWidget" name="pageOutput">
<attribute name="label">
<string>Output</string>
</attribute>
<layout class="QGridLayout" name="gridLayout_2">
<item row="0" column="0">
<widget class="QTextEdit" name="txtOutput">
<property name="readOnly">
<bool>true</bool>
</property>
</widget>
</item>
</layout>
</widget>
</widget>
</item>
</layout>
</widget>
<widget class="QWidget" name="Output">
<attribute name="title">
<string>JSON</string>
</attribute>
<layout class="QGridLayout" name="gridLayout_3">
<item row="0" column="0">
<widget class="QTextEdit" name="txtOutput">
<property name="geometry">
<rect>
<x>0</x>
<y>0</y>
<width>391</width>
<height>411</height>
</rect>
</property>
<property name="sizePolicy">
<sizepolicy hsizetype="Expanding" vsizetype="Expanding">
<horstretch>1</horstretch>
<verstretch>1</verstretch>
</sizepolicy>
</property>
<property name="sizeAdjustPolicy">
<enum>QAbstractScrollArea::AdjustToContents</enum>
</property>
<property name="undoRedoEnabled">
<bool>false</bool>
</property>
<property name="lineWrapMode">
<enum>QTextEdit::NoWrap</enum>
</property>
<property name="readOnly">
<bool>true</bool>
</property>
<property name="textInteractionFlags">
<set>Qt::TextSelectableByKeyboard|Qt::TextSelectableByMouse</set>
</property>
</widget>
</item>
</layout>
Expand Down