Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

freeze.py: Add paths to moved Windows DLLs #3390

Merged
merged 1 commit into from
Apr 23, 2020
Merged

freeze.py: Add paths to moved Windows DLLs #3390

merged 1 commit into from
Apr 23, 2020

Conversation

ferdnyc
Copy link
Contributor

@ferdnyc ferdnyc commented Apr 19, 2020

This branch fixes the Windows builders' freezing of the application, after the DLL files are relocated from lib to bin under the install prefix. bin/ is the correct install subdirectory for Windows DLLs (and every system DLL is in C:\msys64\mingw64\bin), so we would do better to follow convention.

@ferdnyc
Copy link
Contributor Author

ferdnyc commented Apr 19, 2020

(Note that OpenShot/libopenshot-audio#96 and OpenShot/libopenshot#501 make precisely such a change, so this is in anticipation of those PRs being merged. However, there's no harm in doing this either way, since it only adds to the possible search locations for files — no existing functionality is affected.)

@ferdnyc ferdnyc merged commit a22fa5d into develop Apr 23, 2020
@ferdnyc ferdnyc deleted the appveyor branch April 23, 2020 06:41
@ferdnyc ferdnyc restored the appveyor branch April 23, 2020 06:41
@ferdnyc ferdnyc deleted the appveyor branch April 23, 2020 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant