Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export: Don't double file extensions #3088

Merged
merged 1 commit into from
Nov 25, 2019
Merged

Export: Don't double file extensions #3088

merged 1 commit into from
Nov 25, 2019

Conversation

ferdnyc
Copy link
Contributor

@ferdnyc ferdnyc commented Nov 20, 2019

If the user includes the format string (extension) at the end of their filename, don't add it again.

Fixes #2510

@ferdnyc ferdnyc added the closer This PR fixes one or more reported Issues label Nov 20, 2019
@ferdnyc ferdnyc mentioned this pull request Nov 20, 2019
Closed
@SuslikV
Copy link
Contributor

SuslikV commented Nov 25, 2019

Should be merged this year, I think. This is simple fix. With this the behavior is much better than without (at least for me).

@ferdnyc
Copy link
Contributor Author

ferdnyc commented Nov 25, 2019

I will count that as a review, thanks! Merging. 😁

@ferdnyc ferdnyc merged commit 211eed6 into OpenShot:develop Nov 25, 2019
@ferdnyc ferdnyc deleted the export-extension branch November 25, 2019 14:45
@ferdnyc ferdnyc mentioned this pull request Dec 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
closer This PR fixes one or more reported Issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Name of the exported video without double extension
2 participants
@ferdnyc @SuslikV