Thumbnail server: Some fixes #3087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferdnyc
commented
Nov 20, 2019
Comment on lines
+154
to
+163
| if not os.path.exists(thumb_path): | ||
| if file_frame == 1: | ||
| # Try ID with no frame # (for backwards compatibility) | ||
| alt_path = os.path.join(info.THUMBNAIL_PATH, "%s.png" % file_id) | ||
| else: | ||
| # Try with ID and frame # in filename (for backwards compatibility) | ||
| alt_path = os.path.join(info.THUMBNAIL_PATH, "%s-%s.png" % (file_id, file_frame)) | ||
|
|
||
| if os.path.exists(alt_path): | ||
| thumb_path = alt_path |
There was a problem hiding this comment.
This relates to this item: "Fix output path for thumbnail generation (don't override with legacy/compatibility path)"
I noticed that, because thumb_path was being overridden by the legacy locations before it was passed to GenerateThumbnail(), the thumbnails were always being generated at the "backwards compatibility" path. That's now fixed, and thumbnails should be created as ProjectName_assets/thumbnail/FILE_ID/frame#.png as presumably intended.
|
This fixes the issue, at least for me, of an otherwise non-functional thumbnail server on Win7 (resulting in an OpenShot that can't import any media files). So, merging... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
send_response_only()to avoid logging (at ERROR level) successful thumbnail loadsmatch()instead offindall(), to avoid unnecessary nesting of result(This covers both the previous "undefined" condition, and IDs that aren't recognized)
logginginstance127.0.0.1), timestamp