Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animated Titles: Use QPlainTextEdit for multi-line #3006

Merged
merged 2 commits into from
Nov 17, 2019

Conversation

ferdnyc
Copy link
Contributor

@ferdnyc ferdnyc commented Sep 17, 2019

Qt offers QPlainTextEdit which is supposed to be slightly faster in some situations than QTextEdit, and since we're always explicitly accessing the content as plain text, it just makes sense.

(Also, another "while I was in there": The QBlenderEvent class was entirely unused, so I yanked it.)

@ferdnyc ferdnyc added the interface GUI / user interface issues (i.e. windows, buttons, scrolling, pop-ups, etc...) label Oct 2, 2019
@jonoomph
Copy link
Member

I could have sworn we use QBlenderEvent, lol. It was tricky to get our own thread to sent UI events back to the Blender dialog... which is what this relates to. But perhaps we implemented that a different way in the end, and this became a left over?

@jonoomph jonoomph merged commit b0a074f into OpenShot:develop Nov 17, 2019
@jonoomph
Copy link
Member

👍

@ferdnyc ferdnyc deleted the blender-qplaintextedit branch November 19, 2019 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
interface GUI / user interface issues (i.e. windows, buttons, scrolling, pop-ups, etc...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants