Blender Python scripts: Code formatting #2994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed that the Python files in `src/blender/scripts` were indented with _tabs_ instead of spaces, and had other weird formatting issues, so I went through each of them and used Atom's Beautify tool (which mostly runs `autopep8` on the file) to fix the formatting, then did a quick visual scan to make sure it didn't do anything too weird.
|
Nice catch! LG |
ferdnyc
commented
Nov 26, 2019
| 'animation': True, | ||
| } | ||
|
|
||
| # INJECT_PARAMS_HERE |
There was a problem hiding this comment.
Whoops! Well, messed this one up. I didn't catch that my reformatting inserted a space here, which breaks this line of the Blender code:
openshot-qt/src/windows/views/blender_listview.py
Lines 532 to 533 in 211eed6
I'll merge a fix in a moment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the Python files in
src/blender/scriptswere indented with tabs instead of spaces, and had other weird formatting issues, so I went through each of them and used Atom's Beautify tool (which mostly runsautopep8on the file) to fix the formatting, then did a quick visual scan to make sure it didn't do anything too weird.