Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Advanced layout #2987

Merged
merged 3 commits into from
Nov 17, 2019
Merged

New Advanced layout #2987

merged 3 commits into from
Nov 17, 2019

Conversation

ferdnyc
Copy link
Contributor

@ferdnyc ferdnyc commented Sep 9, 2019

See #2703. The 2.4.4 layout is just nonsense.

This PR applies the layout proposed in my comment there:

What do people think of this? Obviously it's a little comical at the default window size, because the default window size is FAR too small for the OpenShot interface in its current form, especially if 2/3 of it is going to be dominated by the video preview. But with the window made larger, I think it'd be fairly usable.

(I really don't like Properties on the right. It puts the value on the outside, farther away from the Timeline, with the label in between them. That's just bad ergonomics.)

Screenshot from 2019-07-18 22-03-24

It also removes window_splitter and window_splitter2 from the settings file, as neither of them is used for anything.

ferdnyc added 3 commits July 19, 2019 00:53
Both `window_splitter_pos` and `window_splitter_2_pos` appear in
the default settings file, but neither is ever used for anything.
@ferdnyc ferdnyc added the interface GUI / user interface issues (i.e. windows, buttons, scrolling, pop-ups, etc...) label Sep 26, 2019
@jonoomph
Copy link
Member

Well, I like it! We will soon be revisiting the layouts in the next version of OpenShot, so I like the idea of improving ergonomics in the meantime.

@jonoomph jonoomph merged commit 7dc30f1 into OpenShot:develop Nov 17, 2019
@ferdnyc ferdnyc deleted the advanced-layout branch November 19, 2019 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
interface GUI / user interface issues (i.e. windows, buttons, scrolling, pop-ups, etc...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants