Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for empty/null path strings #2864

Merged
merged 1 commit into from
Jul 18, 2019
Merged

Check for empty/null path strings #2864

merged 1 commit into from
Jul 18, 2019

Conversation

ferdnyc
Copy link
Contributor

@ferdnyc ferdnyc commented Jul 12, 2019

  • If os.path.exists() is passed a null argument (say, if it came from a user's JSON data), it will throw a TypeError exception. Protect export.py against this. Also correct a typo.
  • Refactored some path-related logic in main_window.py

Fixes #2850 reported by @dadkins1

@ferdnyc
Check for empty/null path strings
77a3a68 
If os.path.exists() is passed a null argument
(say, if it came from a user's JSON data), it
will throw a TypeError exception.
@DylanC
Copy link
Collaborator

DylanC commented Jul 18, 2019

@ferdnyc - Happy to get this one in. Null checking is very sensible for any project.

@DylanC DylanC merged commit 42311aa into OpenShot:develop Jul 18, 2019
@ferdnyc ferdnyc deleted the check-null-paths branch July 19, 2019 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DylanC DylanC DylanC left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pressing Export Does Nothing (Workaround Included)
2 participants
@ferdnyc @DylanC