Make scrolls of the Timeline thicker #2819
Conversation
6px is too low value for the scroll to handle it normally. Make scrolls thicker and use DPI independent units to set new values.
|
@SuslikV You should check out #1883, and the feedback that was provided there concerning the scrollbar in particular. (Your change makes sense, I think it's a good one. But there's more that could be done, if you'd be interested. Some users made some excellent points about how the current scrollbar setup does and doesn't meet their needs, and how it could be better.) |
|
Thank you for the feedback. I made small changes to styles. Now it looks like this:
|
The bright gradient border for whole scroll's track is added. It helps to navigate OpenShot Timeline by scroll while preserving overall UI styling. The not used scroll's corner element removed.
|
Hmm, I found that width of the scrolls either mentioned or hardcoded in some other place of the Timeline too. Because with this change, the far right position of both the Timeline cursor and the horizontal scroll makes cursor broke apart into two elements shifted horizontally (the more width of the vertical scroll - the bigger shift is). It is connected to the Timeline's ruler size and scroll area size (unfortunately, Timeline cursor can be placed outside the scroll area in OpenShot, so someone used scroll's width as hardcoded stuff during development, I think). Yeah, It needs more time to investigate. |
Only for clear reading - here object width is divided by 2 (to get offset of the middle) and the central line is shifted by the same amount.
At far right position of the horizontal scroll the cursor and cursor-line breaks apart and gets amall horizontal shift. The canvas of the ruler rendered slightly bigger to eliminate this shift. When width of the vertical scroll was enlarged - the corresponding final width of the ruler needs to be enlarged to fully cover new width of the scroll bars.
|
I thought that here was my comment. I will write it again... |
|
Style was fixed. Now, the screenshot I've posted earlier should actually reflect current PR state. |
Remove background property from the track (to make track's corners transparent). Use box-shadow in scrollbar styling for code unification.
Use box-shadow instead of webkit specific property. Mainly for code unification purposes.
|
@ferdnyc - I could merge this in if you don't want to wait too long for a review. Seems like a safe change to merge. |
|
(Hmmm, now how do I get my own PRs reviewed? 😇 I'm just not comfortable merging my own code into a collaborative project — not unless I can say that I believe it's literally impossible for it to cause any problems. I figure there's almost nothing so urgent that it can't wait on a second-party sanity check.) |
6px is too low value for the scrolls to handle it normally.
Hi-DPI displays can worsen situation.
The editor misses fast "hand" tool and default browser panning
tools is not very suitable for horizontal scrolling.
Application has few issues with zoom level and snapping, so
Ctrl + Mouse Wheel action is not useful too.
I'm using horizontal scrolling of the Timeline constantly, so
wish to have it slightly bigger controls to not aim precisely each
time I need to scroll the Timeline to the desirable position.
Before
After
