Improving UTF-8 path detection and conversion #2525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rel (i.e. saving project)
…(prior to any backslash replacing), and then re-encode the paths. This is to prevent breaking the JSON.
…rials are visible
…ths without breaking them
…olders and file names)
…(due to crashes in Windows)
…place (for large projects with hundreds or thousands of matches)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some regressions caused by an earlier one and gives a big boost to opening and saving project performance, along with UTF-8 support for file and folder paths contained in an OSP project. Essentially, every single file path contained in the OSP file is now always saved (and escaped) to a relative path, and when an OSP file is opened, the relative paths are converted back to absolute paths in memory. Also tested is the ability to move a self contained folder (folder with OSP file and assets) to any other location on the computer, or another OS (such as move a project folder from Linux to Windows), and everything still works perfectly, even if UTF-8 characters are used, and switching between Windows and Linux slashes (\ vs /).