Discard history on project-file save/load #2468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* updates.py: add newline at end of file
* conversion: total_size() for data structs
* project_data: Log load and save operations
Believe it or not, in all the logging OpenShot does, never was the fact
that a project file was being loaded or saved actually logged as such.
Now it is, complete with the `file_path`.
* project_data: Discard history
On both load and save of project file data, any `"history"` in the JSON
will be discarded, replaced with an empty struct:
`{ "undo": [], "redo": [] }`
Temporarily, while testing the feature, the total size of the data
structure being discarded will first be computed and logged.
```
project_data:INFO Discarding history of size 105246892 bytes
```
…urpose. Soon we need to revisit this and try and improve the persistance of history (within reason to a few dozen changes perhaps), and ensure we don't allow nested histories (since history is an attribute of a project object).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging changes from #2400 into develop, to reduce size of history in project file. Still need to revisit in the future to see why nested history was happening in the project file (ballooning the file size)