Copy (cleaned up) xdg icon to src/images #2316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR OpenShot#2083 cleaned up and optimized the application icon in `xdg/openshot-qt.svg`, but the old, crufty, bloated version is still in the tree at `src/images/openshot.svg`. This change copies the cleaned-up version there, so that the version of the icon being loaded (most importantly) in all of the interface `.ui` files is the cleaner, optimized SVG. Eliminates these log messages from OpenShot: ``` link SVGID_18_-5 hasn't been detected! link SVGID_18_-5 hasn't been detected! link SVGID_22_-5 hasn't been detected! link SVGID_24_-2 hasn't been detected! link SVGID_24_-2 hasn't been detected! ``` ...which it turns out were due to structural errors in the uncleaned, unoptimized `openshot.svg`.
|
@ferdnyc - Seems like another safe to merge kinda change. I will spend more time looking/testing the other PR's later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #2083 cleaned up and optimized the application icon in
xdg/openshot-qt.svg, but the old, crufty, bloated version is still in the tree atsrc/images/openshot.svg.This change copies the cleaned-up version there, so that the version of the icon being loaded (most importantly) in all of the interface
.uifiles is the cleaner, optimized SVG.Eliminates these messages on the console, from OpenShot (actually from QtSvg):
...which it turns out were due to (real) structural errors in the uncleaned, unoptimized
openshot.svg.