Useless logs #2313
Merged
Useless logs #2313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eliminate massive startup spam logging: ``` ui_util:INFO Binding event MainWindow:actionSaveAs_trigger ui_util:INFO Binding event MainWindow:actionImportFiles_trigger ``` Approx. reduction: 71 lines of output
The icon loader outputs a **warning** level log message each time it doesn't find an icon in the current theme and has to fall back to the packaged Humanity icons, even though this is a normal and expected action (especially with AppImages). ``` ui_util:WARNING Icon theme gtk-edit not found. Will use backup icon. ui_util:WARNING Icon theme package-upgrade not found. Will use backup icon. ui_util:WARNING Icon theme im-message-new not found. Will use backup icon. ``` Approx. reduction: 15-68 lines of output (depending on icon availability in the current theme)
The effects_model outputs a log message containing just the category name for each effect loaded, which (out of context) is useless, annoying repetition. Actual startup output of 2.4.3: ``` effects_model:INFO category: Video effects_model:INFO category: Video effects_model:INFO category: Video effects_model:INFO category: Video effects_model:INFO category: Video effects_model:INFO category: Video effects_model:INFO category: Video effects_model:INFO category: Video effects_model:INFO category: Video effects_model:INFO category: Video effects_model:INFO category: Video effects_model:INFO category: Video effects_model:INFO category: Video effects_model:INFO category: Video ``` Exact reduction: All of that
|
@ferdnyc - I'm happy to see some less logging. That fallback icon log was especially annoying. 👍 |
Especially since it was a WARNING. #ForSomeReason! OpenShot: "Look out!! Something completely expected and unremarkable just happened!!" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On more than one previous occasion I've started larger, more ambitious efforts in this regard... and ultimately got nowhere with them. So, this time I decided to just make a quick, targeted strike against some of the worst offenders: The log messages that are output every time, on every launch of OpenShot, and exactly the same each time... messages which serve no purpose except to clutter the logs and obscure useful data.
These are those, and this PR eliminates them with prejudice. See individual commit messages for details.