Add compatibility with FFMPEG 7.0

[eclipseo]

channel_layout has been replaced with ch_layout

[codecov]

Codecov Report

Attention: Patch coverage is 88.23529% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 54.91%. Comparing base (a9e34a9) to head (5305e77).

Files	Patch %	Lines
src/FFmpegWriter.cpp	83.33%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #954      +/-   ##
===========================================
+ Coverage    54.26%   54.91%   +0.65%     
===========================================
  Files          182      182              
  Lines        16505    15948     -557     
===========================================
- Hits          8956     8758     -198     
+ Misses        7549     7190     -359     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jonoomph]

@eclipseo Thanks a bunch for taking a stab at this! I've left a few comments for you (sorry for the nitpicks). Mostly looks good, just a few questions and a few ideas to keep the changes tidy. 👍

[jonoomph]

PR: FFmpeg 7 Support in libopenshot-audio

[eclipseo]

So, we no longer need to set c->channels manually? I'm assuming this gets set automatically when channel_layout is assigned below? (in the newer code path)

Yes ch_layour is a structure that contains both the number of channels and the layout at the same time.

I updated various thing according to your notes, could check it?

[jonoomph]

@eclipseo Thanks! Your changes look great, much easier to follow. I'll do some additional testing on this today, just to verify no issues arise from our build servers, and then hopefully get it merged.

[jonoomph]

@eclipseo Build error:

/home/runner/work/libopenshot/libopenshot/src/FFmpegWriter.cpp: In member function ‘AVStream* openshot::FFmpegWriter::add_audio_stream()’:
/home/runner/work/libopenshot/libopenshot/src/FFmpegWriter.cpp:1125:10: error: conflicting declaration ‘uint64_t channel_layout’
 1125 | uint64_t channel_layout;
      |          ^~~~~~~~~~~~~~
/home/runner/work/libopenshot/libopenshot/src/FFmpegWriter.cpp:1084:24: note: previous declaration as ‘const uint64_t channel_layout’
 1084 |         const uint64_t channel_layout = info.channel_layout;
      |                        ^~~~~~~~~~~~~~
/home/runner/work/libopenshot/libopenshot/src/FFmpegWriter.cpp:1136:20: error: assignment of read-only variable ‘channel_layout’
 1136 |     channel_layout = c->channel_layout;
      |     ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~
gmake[2]: *** [src/CMakeFiles/openshot.dir/build.make:398: src/CMakeFiles/openshot.dir/FFmpegWriter.cpp.o] Error 1
gmake[2]: Leaving directory '/home/runner/work/libopenshot/libopenshot/build'
gmake[1]: *** [CMakeFiles/Makefile2:1810: src/CMakeFiles/openshot.dir/all] Error 2
gmake[1]: Leaving directory '/home/runner/work/libopenshot/libopenshot/build'
gmake: *** [Makefile:166: all] Error 2

[eclipseo]

Ha my bad I had reused a variable name.