Skip to content

Conversation

@hhvrc
Copy link
Contributor

@hhvrc hhvrc commented Jun 4, 2025

No description provided.

@hhvrc hhvrc self-assigned this Jun 4, 2025
@hhvrc hhvrc marked this pull request as ready for review June 11, 2025 12:00
@hhvrc hhvrc requested a review from LucHeart June 11, 2025 12:00
@LucHeart LucHeart requested a review from Copilot June 13, 2025 09:38
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a suite of new seeder classes and updates to service registrations to populate the e2e testing database.

  • Added new seeders for PublicShare, Device, OTA Updates, Control Logs, API Tokens, and more.
  • Updated DI registrations in several projects to incorporate the new OpenShockMemDB and OpenShockDB services.
  • Included minor type-related TODO comments in domain models to consider unsigned types for certain fields.

Reviewed Changes

Copilot reviewed 33 out of 33 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
SeedE2E/Seeders/*.cs New seeder classes added for e2e testing database population
SeedE2E/Program.cs Orchestrates seeding of core, API, and audit entities
Common/OpenShockServiceHelper.cs Consolidates DI registration changes for DB and Redis services
Common/OpenShockDb/PublicShareShocker.cs Added TODO to review Cooldown property type
Common/OpenShockDb/DiscordWebhook.cs Added TODO to review WebhookId type
LiveControlGateway/Program.cs, Cron/Program.cs, API/Program.cs Updated service registration patterns
SeedE2E/Fakers and Extensions/*.cs Additional utility classes to support seeder functionality
Comments suppressed due to low confidence (2)

Common/OpenShockDb/PublicShareShocker.cs:9

  • Consider updating the Cooldown property type to an unsigned integer if negative values are not expected. Ensure that any existing logic or data conversions are updated accordingly.
public int? Cooldown { get; set; } // TODO: Should probably be UInt

Common/OpenShockDb/DiscordWebhook.cs:9

  • Evaluate whether WebhookId should be changed to an unsigned long (ulong) to more accurately represent its value range. Review any potential impacts on the rest of the system before making the change.
public required long WebhookId { get; set; } // TODO: This should probably be ulong

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@LucHeart LucHeart merged commit bc9ca80 into develop Jun 13, 2025
9 checks passed
@LucHeart LucHeart deleted the feature/seeder-for-e2e-testing branch June 13, 2025 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants