Fixes and improvements #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

simontaurus merged 35 commits into main from fixes-and-improvements

Nov 26, 2024

Contributor

LukasGold commented Nov 16, 2024

Aggregated fixes and improvements while developing a tutorial

LukasGold requested a review from SimonStier

November 16, 2024 09:43

LukasGold self-assigned this

LukasGold commented

View reviewed changes

Contributor Author

LukasGold left a comment •

edited

Loading

@SimonStier: osw.params is a newly introduced module to gather params object in one place and thereby make them easier to access to all users (not only experts)

LukasGold commented

View reviewed changes

examples/use_express_functions.py Show resolved Hide resolved

LukasGold commented

View reviewed changes

setup.cfg Show resolved Hide resolved

LukasGold commented

View reviewed changes

src/osw/auth.py Show resolved Hide resolved

LukasGold commented

View reviewed changes

src/osw/data/import_utility.py Show resolved Hide resolved

LukasGold commented

View reviewed changes

src/osw/express.py

    
                  # "Entity": "Category:Entity",  # depends on nothing

                  # "Entity": "Category:Entity",  # depends on nothing#

                  "Category": "Category:Category",  # depends on Entity

                  "Property": "Category:Property",  # depends on Entity

Contributor Author

LukasGold Nov 18, 2024

Adding Category and Property to make sure that the namespace and title functions in osw.model.static are working as expected.
@SimonStier: Should we create a mechanism to ensure installed dependencies other than in osw.express?

LukasGold commented

View reviewed changes

src/osw/express.py Show resolved Hide resolved

LukasGold commented

View reviewed changes

src/osw/express.py Show resolved Hide resolved

LukasGold commented

View reviewed changes

src/osw/model/static.py Show resolved Hide resolved

LukasGold commented

View reviewed changes

src/osw/ontology.py Show resolved Hide resolved

LukasGold commented

View reviewed changes

src/osw/params.py Show resolved Hide resolved

LukasGold commented

View reviewed changes

src/osw/types.py Show resolved Hide resolved

LukasGold commented

View reviewed changes

src/osw/types.py Show resolved Hide resolved

LukasGold commented

View reviewed changes

src/osw/utils/wiki.py Show resolved Hide resolved

LukasGold commented

View reviewed changes

src/osw/utils/wiki.py Show resolved Hide resolved

LukasGold commented

View reviewed changes

src/osw/wtsite.py Show resolved Hide resolved

LukasGold added 12 commits

November 21, 2024 17:50


          README update

6b021be


          import_with_fallback implented and some reformatting

c7d7c2a


          Doc string reformatting

81b3d66


          Reformatting

d7824fc


          Bug fixes and doc improvements to express.py

2cbac21


          Fix import_with_fallback()

df5cecd


          Improvements to usability and readability

22bbbaf


          Fix cases where the default_factory would not be present in the inher…

01f0b1d

…ited model


          Fix: import_with_fallback() & Context Manager for osw_download_file()

c104e39


          Moving some functionality from functions in osw.utils.wiki to methods…

91bd5a2

… of osw.model.static.OswBaseModel


          Making SearchParam available at WtSite.SearchParam

8539b95


          Making openpyxl a requirement for dataimport

b7222f3

LukasGold added 19 commits

November 21, 2024 17:50


          Improvements to import_utility.py - potentially breaking some functio…

5b5060c

…ns, but most likely avoiding unwanted behavior


          Renaming of casted -> transformed

13acb67


          Fixing failing tests due to missing methods (on classes)

76bec5e


          Moving NoneType to a separate module

f63df22


          Validate attributes of OswBaseModel on assignment

df680e0


          Fixing validation errors, causing tests to fail

57957a1


          A collection of the param objects defined in the package

2967d43


          Introducing change id and StoreEntityResult

632a0a1


          Resolving circular import due to identical naming of osw.types

a42fddd


          Minor improvements to express functions

ee3def9


          Small fix to osw.core.OSW.StoreEntityParam

b279ebf


          Still using pydantic.v1

beffddf


          Fixes to QueryInstancesParam & some readability improvements

3f1d047


          Fixing validation error (introduced earlier)

d908a41


          Accompanying changes in the Category:Entity schema

81c51d2


          Deleting empty strings from jsondata to avoid validation errors

8d61b9c


          Added method to delete a list of pages

2af7054


          Fixing params.py: Enums can't be inherited, added new param object

1b2bf1f


          Applying template for Entity.name & Introducing Meta.uuid

e22b0e4

LukasGold force-pushed the fixes-and-improvements branch from e68777f to e22b0e4 Compare

November 21, 2024 16:53

LukasGold added 4 commits

November 21, 2024 21:36


          Merge pull request #93 from OpenSemanticLab/feat-add-rdf-generation

665a189

Feat: add rdf generation
# Conflicts:
#	src/osw/core.py


          Fixing: length of dictionary changed during iteration

c434777


          apply_overwrite_policy() should apply the removal of empty strings

f8959d2


          Fix: Validation error for Entity.label

0d9b87b

list elements of type Label were being passed to Label(), causing validation errors

coveralls commented Nov 22, 2024

Pull Request Test Coverage Report for Build 11969862176

Details

210 of 372 (56.45%) changed or added relevant lines in 12 files are covered.
No unchanged relevant lines lost coverage.
Overall first build on fixes-and-improvements at 52.596%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/osw/utils/wiki.py	18	19	94.74%
src/osw/core.py	44	52	84.62%
src/osw/model/static.py	58	75	77.33%
src/osw/wtsite.py	17	39	43.59%
src/osw/data/import_utility.py	11	41	26.83%
src/osw/express.py	23	56	41.07%
src/osw/params.py	0	51	0.0%

Totals
Change from base Build 11932637168:	52.6%
Covered Lines:	2832
Relevant Lines:	5054

💛 - Coveralls

LukasGold added the enhancement label

simontaurus requested changes

View reviewed changes

Contributor

simontaurus left a comment

I guess all changes are included in #89, see suggestion there

src/osw/core.py Show resolved Hide resolved

src/osw/custom_types.py Show resolved Hide resolved

src/osw/model/entity.py Show resolved Hide resolved

LukasGold requested a review from simontaurus

November 25, 2024 15:08

simontaurus merged commit 0d9b87b into main

9 checks passed

LukasGold deleted the fixes-and-improvements branch

November 28, 2024 08:39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels