-
Couldn't load subscription status.
- Fork 2
Store entity fix (parallel upload for multiply typed items) #86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
25e782d to
233e71f
Compare
Pull Request Test Coverage Report for Build 11686270686Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests ran successfully, desired behavior was achieved
| new_schema["@context"] = schema.pop("@context", None) | ||
| new_schema["title"] = schema.pop("title", "") | ||
| schema["title"] = "Generated" + new_schema["title"] | ||
| schema = new_schema |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SimonStier: Why point to new_schema with schema, if not ever use schema in the code below? Is there a dict.update() call missing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be treated in an additional issue / branch
Before:
Now: