Skip to content

Conversation

@MatPoppFHG
Copy link
Contributor

@MatPoppFHG MatPoppFHG commented Nov 4, 2024

Before:

  • Solely, sequential upload is possible if items to be uploaded have diverse types, resulting in annoying save times. (for each type a parallel upload is performed, resulting essentially in sequential uploads)
    Now:
  • Upload items are first collected in common list then uploaded asynchronously unless parallel=false is actively set.

@coveralls
Copy link

coveralls commented Nov 5, 2024

Pull Request Test Coverage Report for Build 11686270686

Details

  • 25 of 34 (73.53%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on store_entity_fix at 52.835%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/osw/core.py 23 32 71.88%
Totals Coverage Status
Change from base Build 11622161035: 52.8%
Covered Lines: 2589
Relevant Lines: 4599

💛 - Coveralls

@LukasGold LukasGold self-requested a review November 5, 2024 07:37
@LukasGold LukasGold added the enhancement New feature or request label Nov 5, 2024
Copy link
Contributor

@LukasGold LukasGold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests ran successfully, desired behavior was achieved

new_schema["@context"] = schema.pop("@context", None)
new_schema["title"] = schema.pop("title", "")
schema["title"] = "Generated" + new_schema["title"]
schema = new_schema
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonStier: Why point to new_schema with schema, if not ever use schema in the code below? Is there a dict.update() call missing?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be treated in an additional issue / branch

@LukasGold LukasGold merged commit f22138d into main Nov 6, 2024
9 checks passed
@LukasGold LukasGold deleted the store_entity_fix branch November 6, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants