Skip to content

Conversation

@raederan
Copy link
Contributor

Added inital feature to deploy prefect flows using config parameter set.
Fixed deployment_name param as optional for notify_teams function with Microsoft Teams Webhook, cause flow can be also notified without deployment and even if deployment_name is not given for deployment, the UUID will be used instead in teams push notification message.

@raederan raederan requested a review from simontaurus February 20, 2025 14:36
@raederan raederan added the enhancement New feature or request label Feb 20, 2025
@coveralls
Copy link

coveralls commented Feb 20, 2025

Pull Request Test Coverage Report for Build 13583376373

Details

  • 65 of 95 (68.42%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 53.672%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/osw/utils/workflow.py 65 95 68.42%
Totals Coverage Status
Change from base Build 13436547670: 0.4%
Covered Lines: 3227
Relevant Lines: 5648

💛 - Coveralls

Copy link
Contributor

@simontaurus simontaurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

example should also be (also) used as a pytest

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This example should also be used as a pytest

@raederan
Copy link
Contributor Author

@simontaurus added support for python 3.8 syntax and tests

@raederan
Copy link
Contributor Author

also renamed test file from worklfow.py to workflow_test.py to trigger tests for git actions right

@simontaurus simontaurus merged commit 5d492db into main Feb 28, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants