fix(android): generate separate intent-filters for deep links#390
fix(android): generate separate intent-filters for deep links#390AnthonyRonning merged 1 commit intomasterfrom
Conversation
Split the deep-link mobile config into separate entries so the plugin generates individual intent-filters for each path. This ensures proper Android App Links verification for /payment-success, /payment-canceled, and /pricing paths. Removed redundant cloud.opensecret.maple scheme from deep-link config since it's already manually maintained in AndroidManifest.xml. Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
📝 WalkthroughWalkthroughThis pull request modifies the mobile deep-link configuration in the Tauri application, replacing a cloud-based scheme with explicit HTTPS-based routes for payment processing. Three deep-link entries are configured: payment-success, payment-canceled, and pricing, all using https://trymaple.ai as the host with specific path prefixes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
Deploying maple with
|
| Latest commit: |
63cba86
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9ee18961.maple-ca8.pages.dev |
| Branch Preview URL: | https://fix-android-manifest-deep-li.maple-ca8.pages.dev |
Greptile OverviewGreptile SummaryFixed configuration drift between
Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Dev as Developer
participant Config as tauri.conf.json
participant Build as Tauri Build
participant Manifest as AndroidManifest.xml
participant Android as Android System
Note over Dev,Config: Before Fix
Dev->>Config: Multiple paths in single array<br/>["/payment-success", "/payment-canceled", "/pricing"]
Dev->>Build: Run `just android-build`
Build->>Config: Read mobile deep-link config
Build->>Manifest: Generate single intent-filter<br/>with multiple pathPrefix tags
Note over Manifest: ❌ Different from committed version
Note over Dev,Config: After Fix
Dev->>Config: Split into 3 separate entries<br/>One per path
Dev->>Build: Run `just android-build`
Build->>Config: Read mobile deep-link config
Build->>Manifest: Generate 3 separate intent-filters<br/>One per path
Manifest->>Android: Each intent-filter verified independently
Android->>Android: Proper App Links verification<br/>for /payment-success, /payment-canceled, /pricing
Note over Manifest: ✅ Matches committed version
|
Split the deep-link mobile config into separate entries so the plugin generates individual intent-filters for each path. This ensures proper Android App Links verification for
/payment-success,/payment-canceled, and/pricingpaths.Changes:
pathPrefixarray into separate mobile config entriescloud.opensecret.maplescheme from deep-link config (already manually maintained in AndroidManifest.xml outside the auto-generated section)This fixes the issue where running
just android-buildwould regenerate a different AndroidManifest than what was committed.Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.