Fix: Pin tauri-cli to v2.8.0 across all CI workflows#278
Fix: Pin tauri-cli to v2.8.0 across all CI workflows#278AnthonyRonning merged 1 commit intomasterfrom
Conversation
Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
|
Caution Review failedThe pull request is closed. WalkthroughAcross six GitHub workflow files, the Tauri CLI installation step has been updated to pin version 2.8.0 and add the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly related PRs
Poem
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (6)
Comment |
There was a problem hiding this comment.
Greptile Overview
Summary
This PR addresses a critical CI/CD failure by pinning tauri-cli to version 2.8.0 across all 6 GitHub workflow files. The change prevents the broken v2.9.0 from being installed, which was causing compilation errors related to tauri_macos_sign::Error in tauri-bundler v2.7.0.
Key Changes
- Added
--version "2.8.0" --lockedflags to allcargo install tauri-clicommands - Consistent implementation across android-build, claude, desktop-build, mobile-build, release, and testflight-on-comment workflows
- Preserves all existing environment variables and conditional logic in each workflow
Confidence Score: 5/5
- This PR is safe to merge with no risk - it's a straightforward version pin to fix broken CI
- The changes are minimal, consistent, and directly address a known build failure. All modifications follow the same pattern (adding version and --locked flags), preserve existing workflow logic, and only affect CI/CD infrastructure without touching application code. The --locked flag ensures reproducible builds by using exact dependency versions from Cargo.lock.
- No files require special attention - all changes are identical in pattern and purpose
Important Files Changed
File Analysis
| Filename | Score | Overview |
|---|---|---|
| .github/workflows/android-build.yml | 5/5 | Pinned tauri-cli to v2.8.0 with --locked flag in conditional install block |
| .github/workflows/claude.yml | 5/5 | Pinned tauri-cli to v2.8.0 with --locked flag, preserves CARGO_CFG_TARGET_OS=linux prefix |
| .github/workflows/desktop-build.yml | 5/5 | Pinned tauri-cli to v2.8.0 with --locked flag in direct install command |
| .github/workflows/mobile-build.yml | 5/5 | Pinned tauri-cli to v2.8.0 with --locked flag, includes getrandom workaround comment |
| .github/workflows/release.yml | 5/5 | Pinned tauri-cli to v2.8.0 with --locked flag in conditional install block |
| .github/workflows/testflight-on-comment.yml | 5/5 | Pinned tauri-cli to v2.8.0 with --locked flag, includes getrandom workaround comment |
Sequence Diagram
sequenceDiagram
participant Dev as Developer
participant GH as GitHub Actions
participant Cargo as Cargo Registry
participant Build as Build Process
Dev->>GH: Push/PR/Comment Trigger
GH->>GH: Checkout & Setup Environment
GH->>Cargo: cargo install tauri-cli --version "2.8.0" --locked
Note over Cargo: Previously: installed v2.9.0 (broken)<br/>Now: installs v2.8.0 (working)
Cargo-->>GH: tauri-cli v2.8.0 installed
GH->>Build: Execute tauri build commands
Note over Build: No more tauri_macos_sign::Error<br/>compilation failures
Build-->>GH: Build artifacts
GH-->>Dev: CI/CD Success
6 files reviewed, no comments
Problem
The deploy-testflight workflow was failing because
cargo install tauri-cliwas installing the broken v2.9.0, which has a compilation error in tauri-bundler v2.7.0 with tauri_macos_sign::Error.Solution
Pin all CI workflows to use
tauri-cli v2.8.0(the version that works locally) by adding--version "2.8.0" --lockedto allcargo install tauri-clicommands.Workflows Updated
Testing
This ensures consistent tauri-cli versions across all CI/CD pipelines and avoids the v2.9.0 compilation bug.
Summary by CodeRabbit