Skip to content

cachedb_redis: add Redis cluster hash tag support to redisHash #3815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NormB wants to merge 1 commit into
base: master
Choose a base branch
from
+29 −1
Open

cachedb_redis: add Redis cluster hash tag support to redisHash #3815

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 29 additions & 1 deletion modules/cachedb_redis/cachedb_redis_utils.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,35 @@ uint16_t crc16(const char *buf, int len)

unsigned int redisHash(redis_con *con, str* key)
{
return crc16(key->s,key->len) & con->slots_assigned;
int s, e;
char *k;
int klen;

if (!key || !key->s || key->len <= 0) {
LM_ERR("redisHash called with invalid key\n");
return 0;
}

k = key->s;
klen = key->len;

/* Hash tag extraction per Redis cluster spec:
* If key contains {substring}, hash only the substring */
for (s = 0; s < klen; s++)
if (k[s] == '{') break;

if (s < klen) {
for (e = s + 1; e < klen; e++)
if (k[e] == '}') break;

if (e < klen && e != s + 1) {
LM_DBG("hash tag detected: hashing '%.*s' from key '%.*s'\n",
e - s - 1, k + s + 1, klen, k);
return crc16(k + s + 1, e - s - 1) & 16383;
}
}

return crc16(k, klen) & 16383;
}

cluster_node *get_redis_connection(redis_con *con,str *key)
Expand Down
Loading