Skip to content

Conversation

@dsandras
Copy link
Contributor

There are several reasons behind this change:

  1. Other callbacks are only triggered once for each state change.
  2. SNOM phones send several 180 Ringing messages in a row. That triggers
    several early dialog callbacks, which in turn trigger several PUBLISH
    and NOTIFY through the pua_dialoginfo module. This can potentially lead
    to problems.

If accepted, please credit Damien Sandras from Be IP s.a. @ http://www.beip.be

There are several reasons behind this change:
1) Other callbacks are only triggered once for each state change.
2) SNOM phones send several 180 Ringing messages in a row. That triggers
several early dialog callbacks, which in turn trigger several PUBLISH
and NOTIFY through the pua_dialoginfo module. This can potentially lead
to problems.
@ghost ghost assigned bogdan-iancu Jul 31, 2013
@bogdan-iancu
Copy link
Member

Indeed, it makes sense.

bogdan-iancu added a commit that referenced this pull request Jul 31, 2013
Trigger exactly one callback per early state change.
Credits go to Damien Sandras from Be IP s.a. @ http://www.beip.be
@bogdan-iancu bogdan-iancu merged commit ab8b4fe into OpenSIPS:1.8 Jul 31, 2013
@dsandras dsandras deleted the ds-dialog-cb-early-once branch August 1, 2013 06:56
@dsandras dsandras deleted the ds-dialog-cb-early-once branch August 22, 2013 14:12
@mnunzi mnunzi mentioned this pull request Nov 7, 2013
@ankogan ankogan mentioned this pull request Feb 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants