Ds better pua dialoginfo #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several fixes here:
- Dialog callbacks are now correctly setup after a restart of
OpenSIPS. In other words, restarting OpenSIPS will not lead to ghost BLFs
anymore.
- Added an option allowing not to publish state change in case of reINVITE.
- Added an option allowing not to publish state change in trying state.
In other words, a PUBLISH will be sent only when OpenSIPS has received a
18x response type and not before.
Without that patch, when OpenSIPS does not find any active dialog and needs to NOTIFY that state, it correctly sends a full state dialog information, but the XML document is wrong. This is the wrong format, the one that was used: <dialog-info xmlns="urn:ietf:params:xml:ns:dialog-info" version="0" state="partial" entity="sip:752@ds.local.beip.be"><dialog id="752"><state>terminated</state></dialog></dialog-info> (info is not partiali but full, dialog id is wrong). This is the correct format: <dialog-info xmlns="urn:ietf:params:xml:ns:dialog-info" version="6" state="full" entity="sip:753@ds.local.beip.be"/>
Disabling PUBLISH on reINVITEs has some side effects when being used with session timers. More specifically, the session timer could be refresh, but the PUA PUBLISH could expire because it is not refreshed at the same time of the dialog when being setup with the initial dialog lifetime.
The number of generated PUBLISH requests is no optimal. Disabled PUBLISHing for in-dialog REQUESTS. PUBLISHing (again) the "confirmed" state when handling OPTIONS, ACK, BYE, and other dialog related requests triggers a mess of useless NOTIFY requests. We only keep PUBLISHing on reINVITE/UPDATEs as that might be required to be compatible with session timers (they refresh the PUBLISH lifetime). Also added a flag to allow inhibiting PUBLISHing for INVITE/UPDATE in-dialog requests. That might be required for "things" like Asterisk reINVITEs for which we do not want rePUBLISHing again our "confirmed" state. Especially useful when you know that Asterisk reINVITEs for INFO, BYE, and so on.
bogdan-iancu
added a commit
that referenced
this pull request
Aug 2, 2013
Ds better pua dialoginfo Thank you for the fixes! Please provide the update on the docs too ! Credits go to Damien Sandras from Be IP s.a. @ http://www.beip.be
Contributor
Author
|
Unfortunately, this pull request is incomplete too. |
bogdan-iancu
added a commit
that referenced
this pull request
Aug 28, 2013
bogdan-iancu
added a commit
that referenced
this pull request
Aug 28, 2013
bogdan-iancu
added a commit
that referenced
this pull request
Aug 28, 2013
bogdan-iancu
added a commit
that referenced
this pull request
Aug 28, 2013
bogdan-iancu
added a commit
that referenced
this pull request
Aug 28, 2013
bogdan-iancu
added a commit
that referenced
this pull request
Aug 28, 2013
Member
|
Fixed, thanks for the noticed. |
Contributor
Author
|
This is now really fixed. Thanks! |
This was referenced Sep 25, 2013
Closed
Closed
Closed
This was referenced Sep 21, 2018
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the way pua dialoginfo and presence dialoginfo work.
If accepted, please credit Damien Sandras from Be IP s.a. @ http://www.beip.be