How to add rport to REGISTER message

[arovetto]

Hi
I'm using with Opensips 2.2dev uac_registrant module to register to an SIP Provider. They said the registration fails because the top most request Via hasn't the rport parameter.

I've tried to add that parameters using a local_route as follows:

local_route {
xlog("L_INFO", "local_route");
if (is_method("REGISTER")) {
xlog("L_INFO", "Sending a REGISTER to $ru");
add_local_rport();
}
}

But it seems to have no effects:

Feb 17 16:45:46 newopensips-cti1 /sbin/opensips[15391]: local_route
Feb 17 16:45:46 newopensips-cti1 /sbin/opensips[15391]: Sending a REGISTER to sip:sip.vohippo.com
Feb 17 16:45:46 newopensips-cti1 /sbin/opensips[15391]: DBG:tm:t_uac: Change in local route -> rebuilding buffer

Is it a bug?
Is there another way to add it?

Thank you

[bogdan-iancu]

@arovetto, the SIP RFC3261 does not require at all the presence of rport during a registration - this is a bogus requirement.
Changes over VIA in local route does not work, as the VIA is internally generated after the local route, so basically you cannot change it.

Regards,
Bogdan

[arovetto]

Thanks @bogdan-iancu,
The requirement is related to the NAT traversal, my SIP Provider has a public IP, and my opensips is behind a NAT. Looking at RFC 6314 (NAT Traversal Practices for Client-Server SIP) at §5.1.1.1 there is an example with a REGISTER with rport used to receive correctly the response through the NAT firewall.
Without adding rport, the provider sends the response to port 5060, instead of the NATTED port.
Thank you

[bogdan-iancu]

@arovetto , could you please try the following patch:
https://gist.github.com/bogdan-iancu/031cdeadfae46e5e467a

and let me know if it does the trick for you.

[arovetto]

I've tried your patch and it works!!

Thank you

[NFhook]

wow. it's here, thank you