crash in v1.11.3 using fifo pres_phtable_list

[telematico]

Hello Devels:

Making some tests with version 1.11.3 I've just discover how to casue a crash simply calling pres_phtable_list using fifo (opensipsctl fifo pres_phtable_list).

I execute this command in a proxy that is not acting as presence server, but must have the presence modules loaded because is using pua_dialoginfo to set dialoginfo to real presence server (another opensips).

I asume the correct behaviour in this proxy should be not return anything (because it really don't have anything in the tables) but never a crash....

The related modules config is:

modparam("presence", "mix_dialog_presence", 1)
modparam("presence", "server_address", "sip:XXX.XXX.XXX.XXX")
modparam("pua", "db_table", "pua_p3")
modparam("pua", "hash_size", 11)
modparam("pua_dialoginfo", "presence_server", "sip:presence@YYY.YYY.YYY.YYY")
modparam("pua_dialoginfo", "caller_spec_param", "$avp(callerSpec)")
modparam("pua_dialoginfo", "callee_spec_param", "$avp(calleeSpec)")

modparam("pua_usrloc", "default_domain", "sip.mydomain.com")
modparam("pua_usrloc", "presence_server", "sip:presence@YYY.YYY.YYY.YYY")

where XXX.XXX.XXX.XXX is my own IP (the ip of the proxy that crash) and YYY.YYY.YYY.YYY is the IP of the real presence server.

All presence related messages are relayed to real presence server or the UACs, with no presence processing in the proxy, except for pua_dialoginfo and pua_usrloc publishing.

In next comment I'll put a backtrace of the generated core. If you need to reproduce the issue I can supply all the info you request.

Regards,
Carlos Oliva

[telematico]

Reading symbols from /usr/sbin/opensips...Reading symbols from /usr/lib/debug/usr/sbin/opensips...done.
done.
[New LWP 12357]

warning: Can't read pathname for load map: Input/output error.
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
Core was generated by `/usr/sbin/opensips -P /var/run/opensips/opensips.pid -m 128 -M 16 -u opensips -'.
Program terminated with signal 11, Segmentation fault.
#0  0x00007ffaf0881095 in tsl (lock=0x8) at ../../db/../evi/../fastlock.h:88
88              asm volatile(
(gdb) bt
#0  0x00007ffaf0881095 in tsl (lock=0x8) at ../../db/../evi/../fastlock.h:88
#1  get_lock (lock=0x8) at ../../db/../evi/../fastlock.h:178
#2  mi_list_phtable (cmd=<optimized out>, param=<optimized out>) at presence.c:672
#3  0x00007ffaf21cd42e in run_mi_cmd (param=0x23cc840, f=<optimized out>, t=0x7ffaf4a583c0, cmd=<optimized out>) at ../../mi/mi.h:109
#4  mi_fifo_server (fifo_stream=fifo_stream@entry=0x23cc600) at fifo_fnc.c:490
#5  0x00007ffaf21ce49d in fifo_process (rank=<optimized out>) at mi_fifo.c:213
#6  0x0000000000480268 in start_module_procs () at sr_module.c:586
#7  0x0000000000418c06 in main_loop () at main.c:865
#8  main (argc=<optimized out>, argv=<optimized out>) at main.c:1634
(gdb) bt full
#0  0x00007ffaf0881095 in tsl (lock=0x8) at ../../db/../evi/../fastlock.h:88
        val = 1
#1  get_lock (lock=0x8) at ../../db/../evi/../fastlock.h:178
        i = 1024
#2  mi_list_phtable (cmd=<optimized out>, param=<optimized out>) at presence.c:672
        rpl_tree = 0x7ffaf4a584a0
        rpl = 0x7ffaf4a584c0
        p = <optimized out>
        i = <optimized out>
        __FUNCTION__ = "mi_list_phtable"
#3  0x00007ffaf21cd42e in run_mi_cmd (param=0x23cc840, f=<optimized out>, t=0x7ffaf4a583c0, cmd=<optimized out>) at ../../mi/mi.h:109
        ret = <optimized out>
#4  mi_fifo_server (fifo_stream=fifo_stream@entry=0x23cc600) at fifo_fnc.c:490
        mi_cmd = <optimized out>
        mi_rpl = 0x7ffaf4a3d018
        hdl = 0x0
        line_len = 38
        file_sep = <optimized out>
        command = 0x7ffaf4a53cf9 "pres_phtable_list"
        file = 0x7ffaf4a54110 "/tmp/osips_rply_2c1ac483"
        f = 0x7ffaf4a3d018
        reply_stream = 0x23cc840
        __FUNCTION__ = "mi_fifo_server"
#5  0x00007ffaf21ce49d in fifo_process (rank=<optimized out>) at mi_fifo.c:213
        fifo_stream = 0x23cc600
        __FUNCTION__ = "fifo_process"
#6  0x0000000000480268 in start_module_procs () at sr_module.c:586
        m = 0x7ffaf49d6b20
        n = <optimized out>
        l = <optimized out>
        x = <optimized out>
        __FUNCTION__ = "start_module_procs"
#7  0x0000000000418c06 in main_loop () at main.c:865
        i = <optimized out>
        pid = <optimized out>
        si = <optimized out>
        startup_done = 0x0
        chd_rank = 0
        rc = <optimized out>
        load_p = 0x0
#8  main (argc=<optimized out>, argv=<optimized out>) at main.c:1634
        cfg_log_stderr = <optimized out>
        cfg_stream = 0x2373010
        c = <optimized out>
        r = <optimized out>
        tmp = 0x7fff62d69e8a ""
        tmp_len = <optimized out>
        port = <optimized out>
        proto = <optimized out>
        options = 0x52a640 "f:cCm:M:b:l:n:N:rRvdDFETSVhw:t:u:g:P:G:W:o:"
        ret = -1
        seed = 3083195238
        rfd = <optimized out>
        __FUNCTION__ = "main"

[bogdan-iancu]

Hi @telematico - I uploaded a commit to fix the crash ; the fix disables the MI commands in presence module when used in library mode.
Still, if you want to use pua_dialoginfo, only pua module is required; presence module is not (if you have another OpenSIPS acting as presence server......What modules does require presence module in your case ??
Thanks, Bogdan

[telematico]

Hi @bogdan-iancu you are right, I only need pua for pua_dialoginfo and pua_usrloc. Include presence modules was my mistake, are not necesary, thanks for the point.
Nowadays i think your patch is essential because avoid the crash, I will apply it.

Thank you so much