Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support SIP parameters in dispatcher destination #280

Merged
merged 3 commits into from
Jul 20, 2023
Merged

Support SIP parameters in dispatcher destination #280

merged 3 commits into from
Jul 20, 2023

Conversation

AustinLangston
Copy link
Contributor

No description provided.

@AustinLangston AustinLangston mentioned this pull request Jun 9, 2023
Closed
@vladpaiu vladpaiu self-requested a review July 4, 2023 09:12
vladpaiu
vladpaiu requested changes Jul 4, 2023
View reviewed changes
Copy link
Member

@vladpaiu vladpaiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Austin,

I'd allow any transport= potential value here, since we might also have ws, wss or who knows what other protocols might come in the future :)

@bogdan-iancu
Copy link
Member

Or maybe should we allow any kind of URI params, not only transport?

@AustinLangston
Copy link
Contributor Author

@vladpaiu, I modified it here to support any combination of parameters

@AustinLangston AustinLangston requested a review from vladpaiu July 19, 2023 12:57
@AustinLangston AustinLangston changed the title Allow transport to be specified for dispatcher destination Support SIP parameters in dispatcher destination Jul 19, 2023
@vladpaiu vladpaiu merged commit 675e558 into OpenSIPS:master Jul 20, 2023
@AustinLangston AustinLangston deleted the austinlangston/Dispatcher-accept-tcp-patch branch July 20, 2023 14:21
@bogdan-iancu
Copy link
Member

just for the records, see 14a8406

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladpaiu vladpaiu vladpaiu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AustinLangston @bogdan-iancu @vladpaiu