adding ident support for getting CVE names and urls

[ianwatsonrh]

This PR gives you the ability to query idents from the arf report. In the arf report it is actually the idents that contain the CVE references not the "references" element as shown below.

<Rule selected="true" id="xccdf_com.redhat.rhsa_rule_oval-com.redhat.rhsa-def-20140675" severity="high">
    <title>RHSA-2014:0675: java-1.7.0-openjdk security update (Critical)</title>
    <ident system="https://rhn.redhat.com/errata">RHSA-2014-0675</ident>
    <ident system="http://cve.mitre.org">CVE-2014-0429</ident>
    <ident system="http://cve.mitre.org">CVE-2014-0446</ident>
    ...

[isimluk]

I noticed trailing whitespace here.

It's nitpick, but I would feel better if we could get these fixed.

[isimluk]

Did you perhaps mean to say indents ? Not sure whether this is a typo or legit.

[isimluk]

Sure, I can fix this one for you.

[isimluk]

Thank You!

Looks good, didn't test yet.

Could you please write a test or two?

[isimluk]

extra whitespaces

[isimluk]

ditto.

[isimluk]

I think OpenSCAP.xccdf_rule_get_idents will backtrace really hard here if you pass in xccdf:Group element (the crash may occur only on some platforms, but still the risk exists).

You need to put this into the rule.rb.

[isimluk]

❗

[ianwatsonrh]

Good point on the item vs rule. Have moved that across and cleared up the white space.

Will look at writing some tests.

"ident" is intentional as thats the name referred to in the arf schema.

<Rule selected="true" id="xccdf_com.redhat.rhsa_rule_oval-com.redhat.rhsa-def-20140675" severity="high"> <title>RHSA-2014:0675: java-1.7.0-openjdk security update (Critical)</title> <ident system="https://rhn.redhat.com/errata">RHSA-2014-0675</ident> <ident system="http://cve.mitre.org">CVE-2014-0429</ident>

[ianwatsonrh]

@isimluk please review

Added test for ident from a arf file (the way Cloudforms will consume this data)
Linting corrected
Small error on refactoring to rule.rb - missed a import

[isimluk]

I thought we won't need ARF of size 275,156 Bytes just to test idents. I think we could have 1kB ARF file to test that, but I imagine working with all this file formats must be difficult for newcomer.

Anyway, thanks a lot for contribution! And sorrry it took me so long to get this reviewed.