fix: RHICOMPL-3900 disable required ruby version rubocop check#56
Merged
skateman merged 1 commit intoOpenSCAP:masterfrom Jul 13, 2023
Merged
Conversation
marleystipich2
force-pushed
the
disable_required_ruby_check
branch
from
d29e0f1 to
03e6600
Compare
marleystipich2
changed the title
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #56 +/- ##
=======================================
Coverage 37.55% 37.55%
=======================================
Files 10 10
Lines 490 490
=======================================
Hits 184 184
Misses 306 306 ☔ View full report in Codecov by Sentry. |
Contributor
|
I'd say this is not good for consumers of the gem. Having a lower bound is really useful. I assume this only runs on Ruby 2.7+ so at least stating that in the gemspec would be great. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disabling the Gemspec/RequiredRubyVersion because we don't want to limit the supported ruby version because of static analysis.