Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check autotailor unit test dependencies #2155

Merged
merged 2 commits into from
Aug 29, 2024
Merged

Conversation

jan-cerny
Copy link
Member

We will run autotailor unit tests only if pytest is installed on the system. CMake will check for the presence of pytest and enable or disable the unit tests test accordingly.

Fixes: #2153

We will run autotailor unit tests only if pytest is installed
on the system. CMake will check for the presence of pytest and
enable or disable the unit tests test accordingly.

Fixes: OpenSCAP#2153
@jan-cerny jan-cerny marked this pull request as ready for review August 20, 2024 14:20
@Mab879 Mab879 self-assigned this Aug 27, 2024
Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

Having a status message would nice. Everything else looks good.

@@ -127,6 +128,8 @@ find_package(PythonLibs 3)
set(PREFERRED_PYTHON_PATH "${PYTHON_EXECUTABLE}" CACHE PATH "Path to preferred Python")
set(PYTHON3_PATH "${PYTHON_EXECUTABLE}" CACHE PATH "Path to Python3")

find_python_module(pytest)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add status message under the Testing: section that states if PyTest was found or will be ran.

Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Mab879 Mab879 merged commit 0ae322d into OpenSCAP:main Aug 29, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

autotailor-unit-tests unit test runs when pytest is not installed
2 participants