Fix issues reported by OpenScanHub after 1.4.0 release #2152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addressing: 5. openscap-1.4.0/src/XCCDF_POLICY/xccdf_policy_remediate.c:1076:5: alloc_fn: Storage is returned from allocation function "oscap_concat". 6. openscap-1.4.0/src/XCCDF_POLICY/xccdf_policy_remediate.c:1076:5: var_assign: Assigning: "block" = storage returned from "oscap_concat(block, "\n")". 12. openscap-1.4.0/src/XCCDF_POLICY/xccdf_policy_remediate.c:1119:2: leaked_storage: Variable "block" going out of scope leaks the storage it points to.
Addressing: 9. openscap-1.4.0/src/XCCDF_POLICY/xccdf_policy_remediate.c:1835:2: closed_arg: "_generate_kickstart_oscap_post(struct kickstart_commands *, char const *, char const *, struct oscap_source *, int)" closes "output_fd". 11. openscap-1.4.0/src/XCCDF_POLICY/xccdf_policy_remediate.c:1840:3: pass_closed_arg: Passing closed handle "output_fd" as an argument to "_write_text_to_fd". 5. openscap-1.4.0/src/XCCDF_POLICY/xccdf_policy_remediate.c:1638:2: closed_arg: "_write_tailoring_to_fd(struct oscap_source *, int)" closes "output_fd". 6. openscap-1.4.0/src/XCCDF_POLICY/xccdf_policy_remediate.c:1642:2: pass_closed_arg: Passing closed handle "output_fd" as an argument to "_write_text_to_fd". 5. openscap-1.4.0/src/XCCDF_POLICY/xccdf_policy_remediate.c:1638:2: closed_arg: "_write_tailoring_to_fd(struct oscap_source *, int)" closes "output_fd". 6. openscap-1.4.0/src/XCCDF_POLICY/xccdf_policy_remediate.c:1641:2: pass_closed_arg: Passing closed handle "output_fd" as an argument to "_write_text_to_fd". 5. openscap-1.4.0/src/XCCDF_POLICY/xccdf_policy_remediate.c:1638:2: closed_arg: "_write_tailoring_to_fd(struct oscap_source *, int)" closes "output_fd". 6. openscap-1.4.0/src/XCCDF_POLICY/xccdf_policy_remediate.c:1640:2: pass_closed_arg: Passing closed handle "output_fd" as an argument to "_write_text_to_fd". 5. openscap-1.4.0/src/XCCDF_POLICY/xccdf_policy_remediate.c:1638:2: closed_arg: "_write_tailoring_to_fd(struct oscap_source *, int)" closes "output_fd". 6. openscap-1.4.0/src/XCCDF_POLICY/xccdf_policy_remediate.c:1639:2: pass_closed_arg: Passing closed handle "output_fd" as an argument to "_write_text_to_fd_and_free". 2. openscap-1.4.0/src/XCCDF_POLICY/xccdf_policy_remediate.c:1612:2: closed_arg: "oscap_source_to_fd(struct oscap_source *, int)" closes "output_fd". 3. openscap-1.4.0/src/XCCDF_POLICY/xccdf_policy_remediate.c:1613:2: pass_closed_arg: Passing closed handle "output_fd" as an argument to "_write_text_to_fd".
Addresssing: 18. openscap-1.4.0/src/OVAL/probes/independent/textfilecontent_probe.c:217:3: freed_arg: "free" frees "substrs". 22. openscap-1.4.0/src/OVAL/probes/independent/textfilecontent_probe.c:217:3: double_free: Calling "free" frees pointer "substrs" which has already been freed.
evgenyz
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For more details, please read commit messages of all commits.