Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #1928 gh-action to run shellcheck static analyzer #1929

Closed
wants to merge 1 commit into from

Conversation

eslerm
Copy link

@eslerm eslerm commented Feb 10, 2023

This is a minimal gh-action to run shellcheck.

Please see the ShellCheck step for example output: https://github.com/eslerm/openscap/actions/runs/4147791418/jobs/7175079791

shellcheck exits with an error if issues are found.

If the PR is accepted I'll add false positives for shellcheck to ignore.

I set the severity level to warning, since notes are mostly noise.

@jan-cerny
Copy link
Member

Hi @eslerm I agree that shellcheck is very useful. But I'm afraid that now when the code is full of problems and the job is red people will ignore it. Ideally we should make it green or configure in a way that it would show the new issues in the PRs.

@eslerm
Copy link
Author

eslerm commented Feb 20, 2023

Hi @jan-cerny that sounds reasonable to me.

This GitHub Action might be more useful if it always passed, but saved reports somewhere. I'm not sure if or how you would want that implemented though.

Mostly I wanted to bring these reports to your attention, and I had hoped these PRs would be more helpful than a deluge of reports :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants