Remove unused code

[jan-cerny]

This PR removes some unused functions, unimplemented functions and unused header files.

These changes have been split out from #1150 .

[jan-cerny]

I cannot reproduce the CI fail.

[jan-cerny]

@openscap-ci test this please

[yuumasato]

@jan-cerny I was able to reproduce it on a freshly installed Fedora 28 VM.

XCCDF Results are exported correctly.
Stderr file = /tmp/test_remediation_subs_plain_text_empty.out.Ofu6Ae
Result file = /tmp/test_remediation_subs_plain_text_empty.out.1E9Nx6
Title   Ensure that file exists and it is not executable
Rule    xccdf_moc.elpmaxe.www_rule_1
/root/openscap/tests/API/XCCDF/unittests/test_remediation_subs_plain_text_empty.sh: line 34: 11618 Aborted                 (core dumped) $OSCAP xccdf eval --remediate --results $result $srcdir/${name}.xccdf.xml 2> $stderr
…
The following tests FAILED:
	 29 - API/XCCDF/unittests/all.sh (Failed)

[jan-cerny]

@ I'm going to investigate further.

[jan-cerny]

It happens randomly on my Fedora 28 VM, each time in a different test.
I managed to get a backtrace:

#0  0x00007fc5fa57aeab in raise () at /lib64/libc.so.6
#1  0x00007fc5fa5655b9 in abort () at /lib64/libc.so.6
#2  0x00007fc5fa565491 in _nl_load_domain.cold.0 () at /lib64/libc.so.6
#3  0x00007fc5fa573612 in  () at /lib64/libc.so.6                                                                 
#4  0x00007fc5fc35ccbe in  () at /lib64/libpthread.so.0     
#5  0x00007fc5fd30f5b1 in SEAP_desc_unlock (m=0x7fc5e80025a8) at /home/user/openscap/src/OVAL/probes/SEAP/seap-descriptor.h:118                                                                                   
#6  0x00007fc5fd311870 in SEAP_packet_send (ctx=0x7fc5e8000b50, sd=32, packet=0x7fc5d4002da0) at /home/user/openscap/src/OVAL/probes/SEAP/seap-packet.c:878                                                       
#7  0x00007fc5fd312a34 in SEAP_sendmsg (ctx=0x7fc5e8000b50, sd=32, seap_msg=0x7fc5d4002ce0) at /home/user/openscap/src/OVAL/probes/SEAP/seap.c:419                                                                
#8  0x00007fc5fd312c9b in SEAP_reply (ctx=0x7fc5e8000b50, sd=32, rep_msg=0x7fc5d4002ce0, req_msg=0xa9ea40) at /home/user/openscap/src/OVAL/probes/SEAP/seap.c:477                                                 
#9  0x00007fc5fd3072e1 in probe_worker_runfn (arg=0x9d4a60) at /home/user/openscap/src/OVAL/probes/probe/worker.c:126                                                                                             
#10 0x00007fc5fc351594 in start_thread () at /lib64/libpthread.so.0
#11 0x00007fc5fa63de6f in clone () at /lib64/libc.so.6       

[jan-cerny]

The issue is reproducible on current upstream master (as of head 2e25017.)
I have opened an issue #1199 where you can find a traceback.
Therefore this problem is not related to the patches proposed in this PR.

[jan-cerny]

@openscap-ci test this please

[jan-cerny]

@openscap-ci test this please

[jan-cerny]

@openscap-ci test this please

[codecov]

Codecov Report

Merging #1196 into master will increase coverage by 0.19%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1196      +/-   ##
==========================================
+ Coverage   61.83%   62.02%   +0.19%     
==========================================
  Files         275      273       -2     
  Lines       45203    45064     -139     
==========================================
  Hits        27950    27950              
+ Misses      17253    17114     -139

Impacted Files	Coverage Δ
src/OVAL/probes/SEAP/sexp-ID.c	76.66% <ø> (+10.95%)	⬆️
src/OVAL/probes/SEAP/seap-command.c	48.2% <ø> (+0.38%)	⬆️
src/OVAL/probes/SEAP/seap-descriptor.h	54.54% <ø> (ø)	⬆️
src/OVAL/probes/SEAP/generic/strbuf.c	0% <ø> (ø)	⬆️
src/OVAL/probes/SEAP/seap-message.c	98.27% <ø> (+26.12%)	⬆️
src/OVAL/probes/SEAP/sexp-manip_r.c	78.67% <0%> (-0.95%)	⬇️
src/OVAL/probes/probe/worker.c	68.23% <0%> (+0.37%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1171255...dea91f1. Read the comment docs.

[matejak]

Those functions are indeed not used. In case that need for them arises, they are still reachable in git history.
Good job @jan-cerny for finding those orphans!
This PR is good to merge after merge of #1221 and subsequent rebase .

[jan-cerny]

I have rebased it on master.