feat: track completion request origin #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sambarnes
approved these changes
Jan 25, 2024
| payload: CompletionPayload, | ||
| ): | ||
| model_path = get_model_path(payload.model) | ||
| logger.info( | ||
| "Received completion request", extra={"model": str(model_path)} | ||
| "Received completion request", | ||
| extra={ |
There was a problem hiding this comment.
IIRC at opensea we did something that set this context globally for a request so all logs in the call stack used it 🤔 but that's just something in the back of my mind, we can do it later if necessary
There was a problem hiding this comment.
Some of this we'd probably get for free if we transition to data dog tracing anyhow so no point worrying about it now I spose
| "Received completion request", | ||
| extra={ | ||
| "model": str(model_path), | ||
| "user-agent": request.headers.get("user-agent"), |
There was a problem hiding this comment.
I forget if this key needs to be snake_case for datadog to pick it up
alexanderatallah
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Code of Conduct