Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v/b object: parameter for height and width property is not being passed. #356

Open
wants to merge 1 commit into
base: v1.0
Choose a base branch
from

Conversation

danips
Copy link
Contributor

@danips danips commented Jan 8, 2025

@danips danips requested a review from joshua-h January 8, 2025 09:56
@DavidFee-OBS
Copy link

Is this PR still valid? We're using the master branch to develop ORB support for freely and v1.0 for critical bug fixes. See Jason's comment here: https://obs-co.slack.com/archives/C05B5JFBZBL/p1732203143606819

@danips danips changed the base branch from master to v1.0 February 5, 2025 13:25
@danips
Copy link
Contributor Author

danips commented Feb 5, 2025

The issue is already fixed in master, but it is still present in v1.0.
I'll fix the PR when I have time.

@danips danips force-pushed the PR_vb_dimensions_bugfix branch from e4ffbf0 to 1ef00ab Compare February 5, 2025 18:31
@danips
Copy link
Contributor Author

danips commented Feb 5, 2025

PR rebased on top of v1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants