Pass org.hbbtv_DASH-ERRORREP0002 #348
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This has been open for a while? Can this be closed or changed to merged to v1.0? |
When an A/V Control object source is unloaded, the next time it is used it act as it has just been initialised. We can achieve this by storing the old initialising variable into the privates WeakMap, renaming it to unrealized, and setting it to true when unloadSource() is called.
danips
force-pushed
the
pr_DASH-ERRORREP0002
branch
from
1760fc8 to
bdb9a11
Compare
|
This is not fixed I have rebased it on top of v1.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an A/V Control object source is unloaded, the next time it is used it act as it has just been initialised.
We can achieve this by storing the old initialising variable into the privates WeakMap, renaming it to unrealized, and setting it to true when unloadSource() is called.