Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass org.hbbtv_DASH-MISC0010 #347

Open
wants to merge 1 commit into
base: v1.0
Choose a base branch
from

Conversation

danips
Copy link
Contributor

@danips danips commented Oct 18, 2024

Currently ORB only adds HTTP session cookies to the requests inside iframes for HbbTV mime types:

    private static final List<String> HBBTV_MIME_TYPES = Arrays.asList(
            "text/html",
            "application/xhtml+xml",
            "application/xml",
            "application/vnd.hbbtv.xhtml+xml"
    );

The requests for DASH segments need to also contain the cookies to pass org.hbbtv_DASH-MISC0010.
This simply makes all HTTP requests include the cookies.

@danips danips requested a review from joshua-h October 18, 2024 12:59
@DavidFee-OBS
Copy link

This has been open for a while and looks out-of-date. Can this be closed please?

@danips danips closed this Feb 5, 2025
@danips danips reopened this Feb 10, 2025
@danips danips changed the base branch from master to v1.0 February 10, 2025 13:24
@danips
Copy link
Contributor Author

danips commented Feb 10, 2025

I had another look, and the fix still applies to v1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants