Buffer post request so that content-length is always set #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request fixes 1 alert when merging bf3266b into 737625a - view on LGTM.com fixed alerts:
|
|
After making the change I found out about "LoadIntoBufferAsync()" on HttpRequest which might have buffered the response to solve the same problem, but I am not 100% sure without testing |
lindellhugo
reviewed
Aug 25, 2022
src/OpenRiaServices.Client.DomainClients.Http/Framework/Http/BinaryHttpDomainClient.cs
Show resolved
Hide resolved
src/OpenRiaServices.Client.DomainClients.Http/Framework/Http/BinaryHttpDomainClient.cs
Show resolved
Hide resolved
|
This pull request fixes 1 alert when merging 723120a into 1b519d2 - view on LGTM.com fixed alerts:
|
|
This pull request fixes 1 alert when merging 1e73dea into 1b519d2 - view on LGTM.com fixed alerts:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the HttpDomainClient so that it works against the new AspNetCore.Hosting nuget