Skip to content

Add time since last inspection to Rides List window#24080

Merged
tupaschoal merged 5 commits intoOpenRCT2:developfrom
fidwell:ride-list-inspection-time
May 18, 2025
Merged

Add time since last inspection to Rides List window#24080
tupaschoal merged 5 commits intoOpenRCT2:developfrom
fidwell:ride-list-inspection-time

Conversation

@fidwell
Copy link
Contributor

@fidwell fidwell commented Mar 25, 2025

As suggested in #22476. It didn't generate any discussion, but it got a fair number of votes, so I thought I'd take a stab at it.

I had to make the dropdown wider to fit the English text.

image

@fidwell fidwell force-pushed the ride-list-inspection-time branch from f316ad7 to 2bb1020 Compare March 25, 2025 17:13
@fidwell fidwell marked this pull request as ready for review March 25, 2025 17:24
@Gymnasiast Gymnasiast changed the title Add time since last inspection to ride window Add time since last inspection to Rides List window Mar 25, 2025
@fidwell fidwell force-pushed the ride-list-inspection-time branch from d0efdeb to ff8bfb5 Compare April 11, 2025 00:51
Copy link
Member

@tupaschoal tupaschoal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this and it works fine. Not sure the dropdown resize needed to be that long, but probably good to err on the upside given translations. Can you rebase @fidwell ?

Copy link
Contributor

@ZehMatt ZehMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM.

@ZehMatt ZehMatt added this to the v0.4.23 milestone May 17, 2025
@ZehMatt ZehMatt added the changelog This issue/PR deserves a changelog entry. label May 17, 2025
@fidwell fidwell force-pushed the ride-list-inspection-time branch from c056e05 to 30b1eff Compare May 18, 2025 01:33
@tupaschoal tupaschoal enabled auto-merge (squash) May 18, 2025 09:47
@tupaschoal tupaschoal merged commit 736d944 into OpenRCT2:develop May 18, 2025
22 checks passed
@fidwell fidwell deleted the ride-list-inspection-time branch May 18, 2025 15:23
tupaschoal added a commit to klusark/OpenRCT2 that referenced this pull request Aug 6, 2025
…ndow (OpenRCT2#24080)

* Add time since last inspection to ride window

* Changelog

* Add missing entry to ride_info_type_money_mapping
Make dropdown wider

* Consistent formatting

* Update distribution/changelog.txt

---------

Co-authored-by: Tulio Leao <tupaschoal@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog This issue/PR deserves a changelog entry.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants