Scripting: Limit triggering Translation Check#3310
Merged
tupaschoal merged 1 commit intoOpenRCT2:masterfrom Aug 11, 2025
Merged
Scripting: Limit triggering Translation Check#3310tupaschoal merged 1 commit intoOpenRCT2:masterfrom
tupaschoal merged 1 commit intoOpenRCT2:masterfrom
Conversation
limit running Translation Check only to PR's that modify .txt files in data/language
Check resultsFor details click the build job and expand
Other translations
|
tupaschoal
approved these changes
Aug 11, 2025
Member
tupaschoal
left a comment
There was a problem hiding this comment.
Great change, I've always thought about doing this but never took the time to actually do it, thank you ;)
Contributor
Author
|
you are welcome :) |
rmnvgr
pushed a commit
to rmnvgr/Localisation
that referenced
this pull request
Aug 13, 2025
…2#3310) limit running Translation Check only to PR's that modify .txt files in data/language
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Limit running Translation Check only to PR-s that touch text files in data/language
Due to reason that it is unnecessary to re-run it when e.g. GitHub workflows are being modified, or when objects JSONs are being modified, since it does not perform any operations with aforementioned.
This change bring benefits:
🌿 removes unnecessary actions performed by computers, which consume electricity, therefore it is ecological
😌 committers and maintainers will receive less unwanted messages, and thus will be calmer
#️less reports passing thru discord #github
I had tested this (made a mock-up copy of this repository and testing modifications on that (since on fork one needs to be in master, which I find inconvenient)