Skip to content

Scripting: Limit triggering Translation Check#3310

Merged
tupaschoal merged 1 commit intoOpenRCT2:masterfrom
tygrysek90:scripting-limit-translation-check-trigger
Aug 11, 2025
Merged

Scripting: Limit triggering Translation Check#3310
tupaschoal merged 1 commit intoOpenRCT2:masterfrom
tygrysek90:scripting-limit-translation-check-trigger

Conversation

@tygrysek90
Copy link
Contributor

Limit running Translation Check only to PR-s that touch text files in data/language

Due to reason that it is unnecessary to re-run it when e.g. GitHub workflows are being modified, or when objects JSONs are being modified, since it does not perform any operations with aforementioned.


This change bring benefits:

🌿 removes unnecessary actions performed by computers, which consume electricity, therefore it is ecological
😌 committers and maintainers will receive less unwanted messages, and thus will be calmer
#️less reports passing thru discord #github


I had tested this (made a mock-up copy of this repository and testing modifications on that (since on fork one needs to be in master, which I find inconvenient)

limit running Translation Check only to PR's that modify .txt files in data/language
@github-actions
Copy link

Check results

For details click the build job and expand Run checks on the CI logs.

MissingThe translation is not added to translation file. (e.g. STR_9999 is in en-GB but is not available in given language)

Not neededThe translation file contains entries that are not in en-GB and should be removed (e.g. STR_9999 exists in given language but is not in en-GB)

SameThe translation and source string is exactly the same. (e.g. STR_9999 is Umbrella in both en-GB and given language). This may be desired in some cases (e.g. April is the same in English and German)

Other translations

MissingThe translation is not added to translation file. (e.g. STR_9999 is in en-GB but is not available in given language)

Not neededThe translation file contains entries that are not in en-GB and should be removed (e.g. STR_9999 exists in given language but is not in en-GB)

SameThe translation and source string is exactly the same. (e.g. STR_9999 is Umbrella in both en-GB and given language). This may be desired in some cases (e.g. April is the same in English and German)

ar-EG 278 0 1728
ca-ES 19 0 91
cs-CZ 1 0 150
da-DK 14 0 324
de-DE 12 0 147
en-US 3454 0 1
eo-ZZ 3 0 72
es-ES 9 0 166
fi-FI 98 0 95
fr-CA 3619 0 0
fr-FR 3 0 144
gl-ES 3 0 94
hu-HU 1 0 95
it-IT 21 0 138
ja-JP 98 0 121
ko-KR 1 0 95
nb-NO 187 0 162
nl-NL 12 0 184
pl-PL 61 0 99
pt-BR 1 0 142
ru-RU 1 0 118
sv-SE 9 0 161
tr-TR 516 0 98
uk-UA 182 0 719
vi-VN 26 0 117
zh-CN 9 0 36
zh-TW 45 0 115

Copy link
Member

@tupaschoal tupaschoal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great change, I've always thought about doing this but never took the time to actually do it, thank you ;)

@tupaschoal tupaschoal merged commit 4b9b371 into OpenRCT2:master Aug 11, 2025
1 check passed
@tygrysek90
Copy link
Contributor Author

you are welcome :)

rmnvgr pushed a commit to rmnvgr/Localisation that referenced this pull request Aug 13, 2025
…2#3310)

limit running Translation Check only to PR's that modify .txt files in data/language
@tygrysek90 tygrysek90 deleted the scripting-limit-translation-check-trigger branch September 15, 2025 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants